❄ Add InfoBarCompactLayout

❄ Add InfoBarCompactLayout

Adds the ability to create infobars that are "compact":

* Adds an InfoBarCompactLayout that is basically a LinearLayout:
  it sandwiches custom controls in a 48dp high bar between an
  optional icon and a close button.

* Pull out code that creates the icon ImageView and the close
  ImageButton so that it can be reused.

* Add the ability for InfoBar subclasses to define whether or not
  they produce these compact infobars.

* Add some stub code to TranslateCompactInfoBar that allows
  uses this code.

This CL is meant to unblock the Sydney team from progressing;
refinements to the way InfoBar uses the InfoBarCompactaLayout
and the InfoBarLayout classes are forthcoming (along with a doc).

Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDUmlESWpyZHRoeUk

BUG=705312
Review-Url: https://codereview.chromium.org/2767523002
Cr-Commit-Position: refs/heads/master@{#459834}
Committed: https://chromium.googlesource.com/chromium/src/+/7bc9bd3a6fa05f39eab314b3193e2ba382e96b45

[gone, 2017-03-27 00:37:04]

Description was changed from

==========
❄ Experimental compact InfoBar layout

DO NOT SUBMIT.  EXPERIMENTATION ONLY.

Allow hijacking the regular InfoBarLayout pathway to create a special one-liner
layout.

BUG=
==========

to

==========
❄ Add InfoBarCompactLayout

Adds the ability to create infobars that are "compact":

* Adds an InfoBarCompactLayout that is basically a LinearLayout:
  it sandwiches custom controls in a 48dp high bar between an
  optional icon and a close button.

* Add the ability for InfoBar subclasses to define whether or not
  they produce these compact infobars.

* Add some stub code to TranslateCompactInfoBar that allows
  uses this code.

Design docs and tests are forthcoming, though there's really
not much to test here given that the new layout is basically a
LinearLayout.

BUG=705312
==========

[gone, 2017-03-27 00:38:37]

Description was changed from

==========
❄ Add InfoBarCompactLayout

Adds the ability to create infobars that are "compact":

* Adds an InfoBarCompactLayout that is basically a LinearLayout:
  it sandwiches custom controls in a 48dp high bar between an
  optional icon and a close button.

* Add the ability for InfoBar subclasses to define whether or not
  they produce these compact infobars.

* Add some stub code to TranslateCompactInfoBar that allows
  uses this code.

Design docs and tests are forthcoming, though there's really
not much to test here given that the new layout is basically a
LinearLayout.

BUG=705312
==========

to

==========
❄ Add InfoBarCompactLayout

Adds the ability to create infobars that are "compact":

* Adds an InfoBarCompactLayout that is basically a LinearLayout:
  it sandwiches custom controls in a 48dp high bar between an
  optional icon and a close button.

* Pull out code that creates the icon ImageView and the close
  ImageButton so that it can be reused.

* Add the ability for InfoBar subclasses to define whether or not
  they produce these compact infobars.

* Add some stub code to TranslateCompactInfoBar that allows
  uses this code.

This CL is meant to unblock the Sydney team from progressing;
refinements to the way InfoBar uses the InfoBarCompactaLayout
and the InfoBarLayout classes are forthcoming (along with a doc).

BUG=705312
==========

[gone, 2017-03-27 00:39:05]

dfalcantara@chromium.org changed reviewers:
+ twellington@chromium.org

[gone, 2017-03-27 00:39:06]

Theresa: PTAL
Leo: FYI

[gone, 2017-03-27 00:54:40]

Description was changed from

==========
❄ Add InfoBarCompactLayout

Adds the ability to create infobars that are "compact":

* Adds an InfoBarCompactLayout that is basically a LinearLayout:
  it sandwiches custom controls in a 48dp high bar between an
  optional icon and a close button.

* Pull out code that creates the icon ImageView and the close
  ImageButton so that it can be reused.

* Add the ability for InfoBar subclasses to define whether or not
  they produce these compact infobars.

* Add some stub code to TranslateCompactInfoBar that allows
  uses this code.

This CL is meant to unblock the Sydney team from progressing;
refinements to the way InfoBar uses the InfoBarCompactaLayout
and the InfoBarLayout classes are forthcoming (along with a doc).

BUG=705312
==========

to

==========
❄ Add InfoBarCompactLayout

Adds the ability to create infobars that are "compact":

* Adds an InfoBarCompactLayout that is basically a LinearLayout:
  it sandwiches custom controls in a 48dp high bar between an
  optional icon and a close button.

* Pull out code that creates the icon ImageView and the close
  ImageButton so that it can be reused.

* Add the ability for InfoBar subclasses to define whether or not
  they produce these compact infobars.

* Add some stub code to TranslateCompactInfoBar that allows
  uses this code.

This CL is meant to unblock the Sydney team from progressing;
refinements to the way InfoBar uses the InfoBarCompactaLayout
and the InfoBarLayout classes are forthcoming (along with a doc).

Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDUmlESWpyZHRoeUk

BUG=705312
==========

[Theresa, 2017-03-27 15:09:29]

lgtm

https://codereview.chromium.org/2767523002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarCompactLayout.java
(right):

https://codereview.chromium.org/2767523002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarCompactLayout.java:18:
* Lays out an infobar that has all of its controls along a line.
nit: Should this have more information about how to construct/use e.g.
specifically call out that addContent() must be called to populate the middle
part of the infobar?

https://codereview.chromium.org/2767523002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarCompactLayout.java:53:
protected void addContent(View control, float weight) {
nit: This could be any view, not just controls, right? Should the method
name/description reflect that or is the intent that the inserted views will be
"controls"?

https://codereview.chromium.org/2767523002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarCompactLayout.java:66:
* Adds an icon to the left of the infobar, if the infobar requires one.
nit: s/left/start

https://codereview.chromium.org/2767523002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarCompactLayout.java:79:
/** Adds a close button to the right of the infobar. */
nit: s/right/end

[gone, 2017-03-27 16:35:02]

https://codereview.chromium.org/2767523002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarCompactLayout.java
(right):

https://codereview.chromium.org/2767523002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarCompactLayout.java:18:
* Lays out an infobar that has all of its controls along a line.
On 2017/03/27 15:09:29, Theresa wrote:
> nit: Should this have more information about how to construct/use e.g.
> specifically call out that addContent() must be called to populate the middle
> part of the infobar?

Done.

https://codereview.chromium.org/2767523002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarCompactLayout.java:53:
protected void addContent(View control, float weight) {
On 2017/03/27 15:09:29, Theresa wrote:
> nit: This could be any view, not just controls, right? Should the method
> name/description reflect that or is the intent that the inserted views will be
> "controls"?

That was the intent, but I guess generic views are being handled at this point. 
Renamed.

https://codereview.chromium.org/2767523002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarCompactLayout.java:66:
* Adds an icon to the left of the infobar, if the infobar requires one.
On 2017/03/27 15:09:29, Theresa wrote:
> nit: s/left/start

Done.

https://codereview.chromium.org/2767523002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarCompactLayout.java:79:
/** Adds a close button to the right of the infobar. */
On 2017/03/27 15:09:29, Theresa wrote:
> nit: s/right/end

Done.

[gone, 2017-03-27 16:35:08]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2017-03-27 16:35:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2767523002/#ps50001
(title: "❄ Experimental compact InfoBar layout")

[commit-bot: I haz the power, 2017-03-27 16:35:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 18:26:09]

CQ is committing da patch.

Bot data: {"patchset_id": 50001, "attempt_start_ts": 1490632508504440,
"parent_rev": "8f35a712fd404645efbc73aa8a1ce71d6d0078c0", "commit_rev":
"7bc9bd3a6fa05f39eab314b3193e2ba382e96b45"}

[commit-bot: I haz the power, 2017-03-27 18:26:58]

Description was changed from

==========
❄ Add InfoBarCompactLayout

Adds the ability to create infobars that are "compact":

* Adds an InfoBarCompactLayout that is basically a LinearLayout:
  it sandwiches custom controls in a 48dp high bar between an
  optional icon and a close button.

* Pull out code that creates the icon ImageView and the close
  ImageButton so that it can be reused.

* Add the ability for InfoBar subclasses to define whether or not
  they produce these compact infobars.

* Add some stub code to TranslateCompactInfoBar that allows
  uses this code.

This CL is meant to unblock the Sydney team from progressing;
refinements to the way InfoBar uses the InfoBarCompactaLayout
and the InfoBarLayout classes are forthcoming (along with a doc).

Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDUmlESWpyZHRoeUk

BUG=705312
==========

to

==========
❄ Add InfoBarCompactLayout

Adds the ability to create infobars that are "compact":

* Adds an InfoBarCompactLayout that is basically a LinearLayout:
  it sandwiches custom controls in a 48dp high bar between an
  optional icon and a close button.

* Pull out code that creates the icon ImageView and the close
  ImageButton so that it can be reused.

* Add the ability for InfoBar subclasses to define whether or not
  they produce these compact infobars.

* Add some stub code to TranslateCompactInfoBar that allows
  uses this code.

This CL is meant to unblock the Sydney team from progressing;
refinements to the way InfoBar uses the InfoBarCompactaLayout
and the InfoBarLayout classes are forthcoming (along with a doc).

Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDUmlESWpyZHRoeUk

BUG=705312

Review-Url: https://codereview.chromium.org/2767523002
Cr-Commit-Position: refs/heads/master@{#459834}
Committed:
https://chromium.googlesource.com/chromium/src/+/7bc9bd3a6fa05f39eab314b3193e...
==========

[commit-bot: I haz the power, 2017-03-27 18:27:00]

Committed patchset #4 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/7bc9bd3a6fa05f39eab314b3193e...