Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2767473004: Update DeviceMotionEvent IDL to match the specification. (Closed)

Created:
3 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 9 months ago
Reviewers:
timvolodine
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, haraken, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update DeviceMotionEvent IDL to match the specification. In the following pull request I updated the WebIDL for initializing DeviceMotionEvents so that it is consistent with the normative text describing how they should be initialized, https://github.com/w3c/deviceorientation/pull/40 While this changes web-exposed IDL definitions I do not believe that script will be able to tell the difference as the previously specified initialization behavior precluded setting the interval attribute to a null value. BUG=704186 Review-Url: https://codereview.chromium.org/2767473004 Cr-Commit-Position: refs/heads/master@{#459578} Committed: https://chromium.googlesource.com/chromium/src/+/54d4a0fe8de6bb5c31be7e55a2e6c7872a1212f4

Patch Set 1 #

Patch Set 2 : Rebased. #

Messages

Total messages: 20 (13 generated)
Reilly Grant (use Gerrit)
PTAL
3 years, 9 months ago (2017-03-22 17:13:53 UTC) #8
timvolodine
On 2017/03/22 17:13:53, Reilly Grant wrote: > PTAL yes much cleaner thanks! lgtm
3 years, 9 months ago (2017-03-24 18:32:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767473004/1
3 years, 9 months ago (2017-03-24 18:35:13 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/235551) android_cronet on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 9 months ago (2017-03-24 18:40:59 UTC) #13
Reilly Grant (use Gerrit)
Rebased.
3 years, 9 months ago (2017-03-24 20:53:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767473004/20001
3 years, 9 months ago (2017-03-24 20:55:04 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 22:31:01 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/54d4a0fe8de6bb5c31be7e55a2e6...

Powered by Google App Engine
This is Rietveld 408576698