Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2767423002: Worker: Add missing files in BUILD.gn (Closed)

Created:
3 years, 9 months ago by nhiroki
Modified:
3 years, 9 months ago
Reviewers:
kinuko, haraken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, shimazu+worker_chromium.org, kinuko+worker_chromium.org, dglazkov+blink, darin-cc_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Add missing files in BUILD.gn These were reported by tzik@: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/1kK45mVemBc BUG=n/a Review-Url: https://codereview.chromium.org/2767423002 Cr-Commit-Position: refs/heads/master@{#459065} Committed: https://chromium.googlesource.com/chromium/src/+/5d49a6f31e5b223139be4ed83fb0059e5dcd1db6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
nhiroki
3 years, 9 months ago (2017-03-23 11:48:40 UTC) #4
kinuko
lgtm
3 years, 9 months ago (2017-03-23 11:56:59 UTC) #6
haraken
LGTM
3 years, 9 months ago (2017-03-23 11:57:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767423002/1
3 years, 9 months ago (2017-03-23 12:15:19 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 13:51:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d49a6f31e5b223139be4ed83fb0...

Powered by Google App Engine
This is Rietveld 408576698