Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 276733003: Add empty Linux implementation of audio_service. (Closed)

Created:
6 years, 7 months ago by rpaquay
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Add empty Linux implementation of audio_service. BUG=371501 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269433

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -0 lines) Patch
A chrome/browser/extensions/api/audio/audio_service_linux.cc View 1 chunk +87 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 11 (0 generated)
rpaquay
There will be follow up CLs with actual implementation :)
6 years, 7 months ago (2014-05-08 20:43:47 UTC) #1
Marijn Kruisselbrink
lgtm
6 years, 7 months ago (2014-05-08 21:03:39 UTC) #2
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 7 months ago (2014-05-08 21:20:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/276733003/40001
6 years, 7 months ago (2014-05-08 21:22:53 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 01:50:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 04:54:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/14039)
6 years, 7 months ago (2014-05-09 04:54:57 UTC) #7
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 7 months ago (2014-05-09 16:40:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/276733003/40001
6 years, 7 months ago (2014-05-09 16:43:08 UTC) #9
commit-bot: I haz the power
Change committed as 269433
6 years, 7 months ago (2014-05-09 22:18:04 UTC) #10
Lei Zhang
6 years, 5 months ago (2014-07-01 05:37:26 UTC) #11
Message was sent while issue was closed. 
https://codereview.chromium.org/276733003/diff/40001/chrome/chrome_browser_ex...
File chrome/chrome_browser_extensions.gypi (right):

https://codereview.chromium.org/276733003/diff/40001/chrome/chrome_browser_ex...
chrome/chrome_browser_extensions.gypi:139:
'browser/extensions/api/audio/audio_service.cc',
You forgot to exclude this, so the dummy implementation here gets built as well
and used. When I simply changed the ordering, the new Linux AudioServiceImpl
gets used and fails. I've fixed this in
https://codereview.chromium.org/354303003

Powered by Google App Engine
This is Rietveld 408576698