Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 354303003: Cleanup: Change chrome/chrome_browser_extensions.gypi to be inclusive rather than exclusive. (Closed)

Created:
6 years, 5 months ago by Lei Zhang
Modified:
6 years, 5 months ago
Reviewers:
brettw, rpaquay
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanup: Change chrome/chrome_browser_extensions.gypi to be inclusive rather than exclusive. Also fix the build issue with AudioServiceImpl. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280784

Patch Set 1 #

Patch Set 2 : fix build #

Patch Set 3 : fix duplicate AudioServiceImpl #

Patch Set 4 : Lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+614 lines, -718 lines) Patch
M chrome/browser/extensions/api/audio/audio_service_linux.cc View 1 2 3 4 chunks +11 lines, -7 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 26 chunks +603 lines, -711 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Lei Zhang
This should make it easier to convert this to a list to share with GN.
6 years, 5 months ago (2014-06-28 07:33:35 UTC) #1
brettw
lgtm
6 years, 5 months ago (2014-06-30 17:38:55 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-06-30 22:41:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/354303003/20001
6 years, 5 months ago (2014-06-30 22:42:07 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-06-30 23:52:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-01 00:58:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/47401)
6 years, 5 months ago (2014-07-01 00:58:34 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-01 01:04:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/354303003/20001
6 years, 5 months ago (2014-07-01 01:05:20 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-01 02:16:42 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-01 03:33:26 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/47439)
6 years, 5 months ago (2014-07-01 03:33:27 UTC) #12
Lei Zhang
Fixed the build issue with AudioServiceImpl in patch set 3 and 4.
6 years, 5 months ago (2014-07-01 05:39:10 UTC) #13
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-01 05:39:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/354303003/60001
6 years, 5 months ago (2014-07-01 05:39:52 UTC) #15
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 08:32:00 UTC) #16
Message was sent while issue was closed. 
Change committed as 280784

Powered by Google App Engine
This is Rietveld 408576698