Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3075)

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 2767313002: [chromedriver] Return session not created error if version check fails. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome_launcher.cc
diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc
index 1592c2913c813c10936865934ba31f80edf66884..a979be476733f657dfef7677421a275c9710c464 100644
--- a/chrome/test/chromedriver/chrome_launcher.cc
+++ b/chrome/test/chromedriver/chrome_launcher.cc
@@ -222,8 +222,9 @@ Status WaitForDevToolsAndCheckVersion(
"--disable-build-check. Please don't report bugs that "
"cannot be reproduced with this switch removed.";
} else if (browser_info->build_no < kMinimumSupportedChromeBuildNo) {
- return Status(kUnknownError, "Chrome version must be >= " +
- GetMinimumSupportedChromeVersion());
+ return Status(
+ kSessionNotCreatedException,
+ "Chrome version must be >= " + GetMinimumSupportedChromeVersion());
}
while (base::TimeTicks::Now() < deadline) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698