Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2767313002: [chromedriver] Return session not created error if version check fails. (Closed)

Created:
3 years, 9 months ago by samuong
Modified:
3 years, 8 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Return session not created error if version check fails. BUG= Review-Url: https://codereview.chromium.org/2767313002 Cr-Commit-Position: refs/heads/master@{#460454} Committed: https://chromium.googlesource.com/chromium/src/+/907539c74b94bc73c5c5e6359b253723da1c731a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
samuong
ptal, context at b/36529001
3 years, 9 months ago (2017-03-22 23:14:10 UTC) #2
stgao
lgtm
3 years, 9 months ago (2017-03-23 02:04:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767313002/1
3 years, 9 months ago (2017-03-23 02:54:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/304244)
3 years, 9 months ago (2017-03-23 03:09:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767313002/1
3 years, 8 months ago (2017-03-29 17:47:03 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 18:06:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/907539c74b94bc73c5c5e6359b25...

Powered by Google App Engine
This is Rietveld 408576698