More reliable check for whether EGLSyncControlVSyncProvider should be instantiated.

More reliable check for whether EGLSyncControlVSyncProvider should be instantiated.

This change improves a check in NativeViewGLSurfaceEGL::Initialize
for whether it should reset vsync provider. This is done in
preparation for re-introducing ANGLE eglGetSyncValuesCHROMIUM
extension.

The current logic overrides sync provider with a new instance of
EGLSyncControlVSyncProvider when the extension is present and we
want to avoid that since EGLSyncControlVSyncProvider isn't
implemented on Windows.

There is no plan to switch to EGLSyncControlVSyncProvider on Windows.
eglGetSyncValuesCHROMIUM will be used to provide accurate frame
statistics data for instrumentation and benchmarking only.

BUG=614147
Review-Url: https://codereview.chromium.org/2767293002
Cr-Commit-Position: refs/heads/master@{#458996}
Committed: https://chromium.googlesource.com/chromium/src/+/1b27dad7e468ddaaf74d9b483bf14015c9f848e3

[stanisc, 2017-03-22 23:06:10]

Description was changed from

==========
More reliable check for whether EGLSyncControlVSyncProvider should be
instantiated.

BUG=614147
==========

to

==========
More reliable check for whether EGLSyncControlVSyncProvider should be
instantiated.

This change improves a check in NativeViewGLSurfaceEGL::Initialize
for whether it should reset vsync provider. This is done in
preparation for re-introducing ANGLE eglGetSyncValuesCHROMIUM
extension.

The current logic overrides sync provider with a new instance of
EGLSyncControlVSyncProvider when the extension is present and we
want to avoid that since EGLSyncControlVSyncProvider isn't
implemented on Windows.

There is no plan to switch to EGLSyncControlVSyncProvider on Windows.
Instead eglGetSyncValuesCHROMIUM will be used to provide accurate
frame statistics data for instrumentation and benchmarking only.

BUG=614147
==========

[stanisc, 2017-03-22 23:06:45]

Description was changed from

==========
More reliable check for whether EGLSyncControlVSyncProvider should be
instantiated.

This change improves a check in NativeViewGLSurfaceEGL::Initialize
for whether it should reset vsync provider. This is done in
preparation for re-introducing ANGLE eglGetSyncValuesCHROMIUM
extension.

The current logic overrides sync provider with a new instance of
EGLSyncControlVSyncProvider when the extension is present and we
want to avoid that since EGLSyncControlVSyncProvider isn't
implemented on Windows.

There is no plan to switch to EGLSyncControlVSyncProvider on Windows.
Instead eglGetSyncValuesCHROMIUM will be used to provide accurate
frame statistics data for instrumentation and benchmarking only.

BUG=614147
==========

to

==========
More reliable check for whether EGLSyncControlVSyncProvider should be
instantiated.

This change improves a check in NativeViewGLSurfaceEGL::Initialize
for whether it should reset vsync provider. This is done in
preparation for re-introducing ANGLE eglGetSyncValuesCHROMIUM
extension.

The current logic overrides sync provider with a new instance of
EGLSyncControlVSyncProvider when the extension is present and we
want to avoid that since EGLSyncControlVSyncProvider isn't
implemented on Windows.

There is no plan to switch to EGLSyncControlVSyncProvider on Windows.
eglGetSyncValuesCHROMIUM will be used to provide accurate frame
statistics data for instrumentation and benchmarking only.

BUG=614147
==========

[stanisc, 2017-03-22 23:13:25]

The CQ bit was checked by stanisc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 23:14:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stanisc, 2017-03-22 23:19:33]

stanisc@chromium.org changed reviewers:
+ jbauman@chromium.org

[stanisc, 2017-03-22 23:19:34]

PTAL!

Is this covered by any unit tests? I tested this manually on Windows. The change
is trivial but I wanted to make sure this is OK on other platforms.

[jbauman, 2017-03-23 01:14:41]

lgtm

On 2017/03/22 23:19:34, stanisc wrote:
> PTAL!
> 
> Is this covered by any unit tests? I tested this manually on Windows. The
change
> is trivial but I wanted to make sure this is OK on other platforms.

I think we only really have tests for this on the perf bots.

[commit-bot: I haz the power, 2017-03-23 01:23:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 01:23:30]

Dry run: This issue passed the CQ dry run.

[stanisc, 2017-03-23 03:21:19]

The CQ bit was checked by stanisc@chromium.org

[commit-bot: I haz the power, 2017-03-23 03:21:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 03:26:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490239279415580, "parent_rev":
"5f34b644166c2dc02f7f937f69ce0fd08e89e626", "commit_rev":
"1b27dad7e468ddaaf74d9b483bf14015c9f848e3"}

[commit-bot: I haz the power, 2017-03-23 03:27:51]

Description was changed from

==========
More reliable check for whether EGLSyncControlVSyncProvider should be
instantiated.

This change improves a check in NativeViewGLSurfaceEGL::Initialize
for whether it should reset vsync provider. This is done in
preparation for re-introducing ANGLE eglGetSyncValuesCHROMIUM
extension.

The current logic overrides sync provider with a new instance of
EGLSyncControlVSyncProvider when the extension is present and we
want to avoid that since EGLSyncControlVSyncProvider isn't
implemented on Windows.

There is no plan to switch to EGLSyncControlVSyncProvider on Windows.
eglGetSyncValuesCHROMIUM will be used to provide accurate frame
statistics data for instrumentation and benchmarking only.

BUG=614147
==========

to

==========
More reliable check for whether EGLSyncControlVSyncProvider should be
instantiated.

This change improves a check in NativeViewGLSurfaceEGL::Initialize
for whether it should reset vsync provider. This is done in
preparation for re-introducing ANGLE eglGetSyncValuesCHROMIUM
extension.

The current logic overrides sync provider with a new instance of
EGLSyncControlVSyncProvider when the extension is present and we
want to avoid that since EGLSyncControlVSyncProvider isn't
implemented on Windows.

There is no plan to switch to EGLSyncControlVSyncProvider on Windows.
eglGetSyncValuesCHROMIUM will be used to provide accurate frame
statistics data for instrumentation and benchmarking only.

BUG=614147

Review-Url: https://codereview.chromium.org/2767293002
Cr-Commit-Position: refs/heads/master@{#458996}
Committed:
https://chromium.googlesource.com/chromium/src/+/1b27dad7e468ddaaf74d9b483bf1...
==========

[commit-bot: I haz the power, 2017-03-23 03:27:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1b27dad7e468ddaaf74d9b483bf1...