Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2767253005: Implement TOGGLE_EXPANSION action for the ARC notifications. (Closed)

Created:
3 years, 9 months ago by yhanada
Modified:
3 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, Peter Beverloo, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement TOGGLE_EXPANSION action for the ARC notifications. TOGGLE_EXPANSION action will be triggerred when a user triggers DO_DEFAULT accessibility action on the notification. I use the target of the mouse pressing event on ArcCustomNotificationView to distinguish accessibility DO_DEFAULT action and normal click on the notification. This hack will be removed after making |AXActionData| be propagated to |HandleAccessibleAction|. BUG=703989 Review-Url: https://codereview.chromium.org/2767253005 Cr-Commit-Position: refs/heads/master@{#460087} Committed: https://chromium.googlesource.com/chromium/src/+/b7af49bce7ecd2e79c8a54712d27bd45e27c2420

Patch Set 1 #

Patch Set 2 : remove the unused variable #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M ui/arc/notification/arc_custom_notification_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M ui/arc/notification/arc_notification_item.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/arc_notification_item.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/arc/notification/arc_notification_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/arc_notification_manager.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download
M ui/message_center/views/custom_notification_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/views/custom_notification_view.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (25 generated)
yhanada
PTAL. Thanks!
3 years, 9 months ago (2017-03-24 08:18:32 UTC) #2
yoshiki
lgtm with nit https://codereview.chromium.org/2767253005/diff/20001/ui/message_center/views/custom_notification_view.cc File ui/message_center/views/custom_notification_view.cc (right): https://codereview.chromium.org/2767253005/diff/20001/ui/message_center/views/custom_notification_view.cc#newcode162 ui/message_center/views/custom_notification_view.cc:162: if (contents_view_) nit: please add brackets ...
3 years, 9 months ago (2017-03-27 06:04:51 UTC) #15
yhanada
https://codereview.chromium.org/2767253005/diff/20001/ui/message_center/views/custom_notification_view.cc File ui/message_center/views/custom_notification_view.cc (right): https://codereview.chromium.org/2767253005/diff/20001/ui/message_center/views/custom_notification_view.cc#newcode162 ui/message_center/views/custom_notification_view.cc:162: if (contents_view_) On 2017/03/27 06:04:51, yoshiki wrote: > nit: ...
3 years, 9 months ago (2017-03-27 06:26:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767253005/60001
3 years, 8 months ago (2017-03-28 13:59:46 UTC) #27
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 14:04:31 UTC) #30
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b7af49bce7ecd2e79c8a54712d27...

Powered by Google App Engine
This is Rietveld 408576698