Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

Issue 2767233002: Expand git_cl and rebaseline_cl unit tests. (Closed)
Patch Set: fixup Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
index 0edb1f1c0eb123147b937752009d6343ec1c528f..56ec066b44240e5358c9ad6e4c5e343c67053ff5 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
@@ -297,6 +297,13 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):
self.command.builders_with_pending_builds([Build('MOCK Try Linux', None), Build('MOCK Try Win', 123)]),
{'MOCK Try Linux'})
+ def test_builders_with_no_results(self):
+ # In this example, Linux has a pending build, and Mac has no build.
+ # MOCK Try Mac is listed because it's listed in the BuilderList in setUp.
+ self.assertEqual(
+ self.command.builders_with_no_results([Build('MOCK Try Linux', None), Build('MOCK Try Win', 123)]),
+ {'MOCK Try Mac', 'MOCK Try Linux'})
+
def test_bails_when_one_build_is_missing_results(self):
self.tool.buildbot.set_results(Build('MOCK Try Win', 5000), None)
return_code = self.command.execute(self.command_options(), [], self.tool)
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698