Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py

Issue 2767233002: Expand git_cl and rebaseline_cl unit tests. (Closed)
Patch Set: fixup Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
index f2ddfb52f6570ceafcee20171138e05fe4f26205..7dbe5962ef965a3c94c86435df9cd3e86cadd691 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
@@ -180,3 +180,17 @@ class GitCLTest(unittest.TestCase):
self.assertEqual(
git_cl.latest_try_jobs(['builder-a', 'builder-b']),
[Build('builder-a'), Build('builder-b', 100)])
+
+ def test_latest_try_builds_failures(self):
+ git_cl = GitCL(MockHost())
+ git_cl.fetch_try_results = lambda: [
+ {
+ 'builder_name': 'builder-a',
+ 'status': 'COMPLETED',
+ 'result': 'FAILURE',
+ 'url': 'http://build.chromium.org/p/master/builders/some-builder/builds/100',
+ },
+ ]
+ self.assertEqual(
+ git_cl.latest_try_jobs(['builder-a', 'builder-b']),
+ [Build('builder-a', 100)])
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698