Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.h

Issue 2767173002: [MD Extensions] Respond with a load error when loading unpacked fails (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api.h
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.h b/chrome/browser/extensions/api/developer_private/developer_private_api.h
index 607e3029d07975be4212803d74caa8cfccea0998..0a5f59554399462ff19d3d4643e167e573f8b391 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.h
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.h
@@ -395,8 +395,16 @@ class DeveloperPrivateLoadUnpackedFunction
const std::string& error);
private:
+ void OnGotManifestError(const base::FilePath& file_path,
+ const std::string& error,
+ size_t line_number,
+ const std::string& manifest);
+
// Whether or not we should fail quietly in the event of a load error.
- bool fail_quietly_;
+ bool fail_quietly_ = false;
+
+ // Whether we populate a load error on failure.
lazyboy 2017/03/22 21:38:46 nit: populate developer_private::LoadError on fail
Devlin 2017/03/23 01:30:59 Done.
+ bool populate_error_ = false;
};
class DeveloperPrivateChoosePathFunction

Powered by Google App Engine
This is Rietveld 408576698