Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2767143007: Try |View::HandleAccessibleAction| before falling back to fixed actions. (Closed)

Created:
3 years, 9 months ago by yhanada
Modified:
3 years, 8 months ago
Reviewers:
msw, dmazzoni
CC:
chromium-reviews, sadrul, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Try |View::HandleAccessibleAction| before falling back to fixed actions. Currently automation API always do the fixed action for each accessible action. For example, clicking on the center of the target view is always triggered when AX_ACTION_DO_DEFAULT is passed to automation API. This CL makes automation API try to use |View::HandleAccessibleAction| first. This change enables us to implement custom action on accessible actions. BUG=705350 Review-Url: https://codereview.chromium.org/2767143007 Cr-Commit-Position: refs/heads/master@{#460255} Committed: https://chromium.googlesource.com/chromium/src/+/e80b960e27af6495ff3dd79cbfcede18d48da85a

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix the warning #

Patch Set 4 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
M chrome/browser/ui/aura/accessibility/automation_manager_aura.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/aura/accessibility/ax_tree_source_aura.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/views/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_wrapper.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A ui/views/accessibility/ax_aura_obj_wrapper.cc View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M ui/views/accessibility/ax_view_obj_wrapper.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/accessibility/ax_view_obj_wrapper.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 32 (24 generated)
yhanada
PTAL. Thanks!
3 years, 8 months ago (2017-03-28 14:06:42 UTC) #17
dmazzoni
lgtm Thanks! This is fine as-is, I can follow this up with a change that ...
3 years, 8 months ago (2017-03-28 15:02:24 UTC) #20
yhanada
Thank you for reviewing! I submit this change as-is.
3 years, 8 months ago (2017-03-28 22:44:40 UTC) #21
yhanada
Hi msw@, could you review ui/views/BUILD.gn change as the OWNER?
3 years, 8 months ago (2017-03-28 22:50:06 UTC) #25
msw
ui/views/BUILD.gn lgtm
3 years, 8 months ago (2017-03-28 23:58:03 UTC) #26
yhanada
Thank you!
3 years, 8 months ago (2017-03-29 00:24:50 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767143007/60001
3 years, 8 months ago (2017-03-29 00:26:07 UTC) #29
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 01:04:56 UTC) #32
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e80b960e27af6495ff3dd79cbfce...

Powered by Google App Engine
This is Rietveld 408576698