Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2767143004:
libvpx: use bsd-compatible sed expressions (Closed)
Descriptionlibvpx: use bsd-compatible sed expressions
Use [[:space:]] instead of \s for whitespace matching
On OS X, the bsd sed does not support \s
BUG=chromium:704313
Review-Url: https://codereview.chromium.org/2767143004
Cr-Commit-Position: refs/heads/master@{#460102}
Committed: https://chromium.googlesource.com/chromium/src/+/8c8b47a34d4ad141c14fc83e644e3c53edd5b37c
Patch Set 1 #
Messages
Total messages: 29 (15 generated)
johannkoenig@google.com changed reviewers: + jianj@chromium.org
On 2017/03/22 23:06:07, Johann wrote: lgtm. sorry I added one of those out of habit...
The CQ bit was checked by jianj@chromium.org
The CQ bit was unchecked by jianj@chromium.org
On 2017/03/22 23:06:07, Johann wrote: lgtm.
The CQ bit was checked by johannkoenig@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
On 2017/03/22 23:43:32, jzern wrote: > On 2017/03/22 23:06:07, Johann wrote: > > lgtm. sorry I added one of those out of habit... yeah, that was my first thought (not specifically [[:space:]], but something bsd-related) but the lint stuff has been there since inception?
On 2017/03/23 00:50:54, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started once the patch has received an L-G-T-M from a full > committer. > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. I wonder if I can LGTM my own change
On 2017/03/23 00:50:54, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started once the patch has received an L-G-T-M from a full > committer. > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. I wonder if I can LGTM my own change
The CQ bit was checked by johannkoenig@google.com
johannkoenig@google.com changed reviewers: + tomfinegan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Huh, I thought being a committer myself would allow it to accept non-committer approvals. Guess not. Tom, would you take a look please
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by johannkoenig@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/03/23 00:53:59, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started once the patch has received an L-G-T-M from a full > committer. > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. lgtm
The CQ bit was checked by johannkoenig@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490711023134460, "parent_rev":
"1ef537029ee0902ad9a429c5c7a449b41d4f5d8c", "commit_rev":
"8c8b47a34d4ad141c14fc83e644e3c53edd5b37c"}
Message was sent while issue was closed.
Description was changed from ========== libvpx: use bsd-compatible sed expressions Use [[:space:]] instead of \s for whitespace matching On OS X, the bsd sed does not support \s BUG=chromium:704313 ========== to ========== libvpx: use bsd-compatible sed expressions Use [[:space:]] instead of \s for whitespace matching On OS X, the bsd sed does not support \s BUG=chromium:704313 Review-Url: https://codereview.chromium.org/2767143004 Cr-Commit-Position: refs/heads/master@{#460102} Committed: https://chromium.googlesource.com/chromium/src/+/8c8b47a34d4ad141c14fc83e644e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8c8b47a34d4ad141c14fc83e644e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
