Fix position of layer with floating ancestor within inline parent layer

Fix position of layer with floating ancestor within inline parent layer

<span style="position: relative">
  ...
    <div style="float: left">
      ...
        <target layer>
      ...
    </div>
  ...
</span>

Because of the floating ancestor, the containing layer of target layer
is not the span, but the layer found in the containing block chain.

BUG=703666, 703481
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
NOPRESUBMIT=true
NOTRY=true
R=chrishtr

Review-Url: https://codereview.chromium.org/2761413002
Cr-Original-Commit-Position: refs/heads/master@{#458857}
Review-Url: https://codereview.chromium.org/2767133003
Cr-Commit-Position: refs/branch-heads/2987@{#865}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/05de6acd8ec79f95dede0ed751a5be65e8b35c47

[Xianzhu, 2017-03-22 23:10:58]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2017-03-22 23:10:59]

Because of later refactors, the merge is not straight-forward. Ptal.

I've tested with the bug cases and unit tests and all passed.

[chrishtr, 2017-03-22 23:23:33]

I assume you also tested the sites? Do the layout tests pass?

https://codereview.chromium.org/2767133003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):

https://codereview.chromium.org/2767133003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:924: if
(!isSelfPaintingLayer() && m_layoutObject->isFloating() &&
Do you need to fix this one too?

[Xianzhu, 2017-03-22 23:25:17]

https://codereview.chromium.org/2767133003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):

https://codereview.chromium.org/2767133003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:924: if
(!isSelfPaintingLayer() && m_layoutObject->isFloating() &&
On 2017/03/22 23:23:33, chrishtr wrote:
> Do you need to fix this one too?

I would like to keep this as-is, as the compositing issue was not new.

[chrishtr, 2017-03-22 23:27:22]

On 2017/03/22 at 23:25:17, wangxianzhu wrote:
>
https://codereview.chromium.org/2767133003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):
> 
>
https://codereview.chromium.org/2767133003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/paint/PaintLayer.cpp:924: if
(!isSelfPaintingLayer() && m_layoutObject->isFloating() &&
> On 2017/03/22 23:23:33, chrishtr wrote:
> > Do you need to fix this one too?
> 
> I would like to keep this as-is, as the compositing issue was not new.

Ok. Just checking whether this was a possible problem for the proximate bug fix.

And the other questions I raised about testing?

[Xianzhu, 2017-03-22 23:39:43]

On 2017/03/22 23:27:22, chrishtr wrote:
> On 2017/03/22 at 23:25:17, wangxianzhu wrote:
> >
>
https://codereview.chromium.org/2767133003/diff/40001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):
> > 
> >
>
https://codereview.chromium.org/2767133003/diff/40001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/core/paint/PaintLayer.cpp:924: if
> (!isSelfPaintingLayer() && m_layoutObject->isFloating() &&
> > On 2017/03/22 23:23:33, chrishtr wrote:
> > > Do you need to fix this one too?
> > 
> > I would like to keep this as-is, as the compositing issue was not new.
> 
> Ok. Just checking whether this was a possible problem for the proximate bug
fix.
> 
> And the other questions I raised about testing?

I tested with the cases in the bug reports, unit tests and layout tests under
paint/, fast/ and compositing/. All bug cases passed, and no new test failures.

[chrishtr, 2017-03-22 23:42:36]

lgtm

[Xianzhu, 2017-03-22 23:43:56]

Description was changed from

==========
Fix position of layer with floating ancestor within inline parent layer

<span style="position: relative">
  ...
    <div style="float: left">
      ...
        <target layer>
      ...
    </div>
  ...
</span>

Because of the floating ancestor, the containing layer of target layer
is not the span, but the layer found in the containing block chain.

BUG=703666,703481

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2761413002
Cr-Commit-Position: refs/heads/master@{#458857}
==========

to

==========
Fix position of layer with floating ancestor within inline parent layer

<span style="position: relative">
  ...
    <div style="float: left">
      ...
        <target layer>
      ...
    </div>
  ...
</span>

Because of the floating ancestor, the containing layer of target layer
is not the span, but the layer found in the containing block chain.

BUG=703666,703481

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
NOPRESUBMIT=true
NOTRY=true
R=chrishtr

Review-Url: https://codereview.chromium.org/2761413002
Cr-Commit-Position: refs/heads/master@{#458857}
==========

[Xianzhu, 2017-03-22 23:43:59]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-03-22 23:45:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 23:49:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490226239185610,
"parent_rev": "c8352fb469276b9d2d1bcef3fc93f202aa5c2b75", "commit_rev":
"05de6acd8ec79f95dede0ed751a5be65e8b35c47"}

[commit-bot: I haz the power, 2017-03-22 23:49:43]

Description was changed from

==========
Fix position of layer with floating ancestor within inline parent layer

<span style="position: relative">
  ...
    <div style="float: left">
      ...
        <target layer>
      ...
    </div>
  ...
</span>

Because of the floating ancestor, the containing layer of target layer
is not the span, but the layer found in the containing block chain.

BUG=703666,703481

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
NOPRESUBMIT=true
NOTRY=true
R=chrishtr

Review-Url: https://codereview.chromium.org/2761413002
Cr-Commit-Position: refs/heads/master@{#458857}
==========

to

==========
Fix position of layer with floating ancestor within inline parent layer

<span style="position: relative">
  ...
    <div style="float: left">
      ...
        <target layer>
      ...
    </div>
  ...
</span>

Because of the floating ancestor, the containing layer of target layer
is not the span, but the layer found in the containing block chain.

BUG=703666,703481

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
NOPRESUBMIT=true
NOTRY=true
R=chrishtr

Review-Url: https://codereview.chromium.org/2761413002
Cr-Original-Commit-Position: refs/heads/master@{#458857}
Review-Url: https://codereview.chromium.org/2767133003
Cr-Commit-Position: refs/branch-heads/2987@{#865}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/05de6acd8ec79f95dede0ed751a5...
==========

[commit-bot: I haz the power, 2017-03-22 23:49:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/05de6acd8ec79f95dede0ed751a5...