Simplify some arguments inside SelectorQuery.

Simplify some arguments inside SelectorQuery.

We can hoist some code and remove some arguments since we always pass the same
thing.

BUG=703900
Review-Url: https://codereview.chromium.org/2767113003
Cr-Commit-Position: refs/heads/master@{#459011}
Committed: https://chromium.googlesource.com/chromium/src/+/26d67176f9cf8b10fd2a378cb83492e432af23ba

[esprehn, 2017-03-22 20:27:11]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 20:27:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 22:48:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 22:48:20]

Dry run: This issue passed the CQ dry run.

[esprehn, 2017-03-22 22:54:51]

Description was changed from

==========
Simplify some arguments inside SelectorQuery.

BUG=
==========

to

==========
Simplify some arguments inside SelectorQuery.

We can hoist some code and remove some arguments since we always pass the same
thing.

BUG=703900
==========

[esprehn, 2017-03-22 22:54:51]

esprehn@chromium.org changed reviewers:
+ rune@opera.com, sashab@chromium.org

[esprehn, 2017-03-23 01:09:33]

https://codereview.chromium.org/2767113003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/SelectorQuery.cpp (left):

https://codereview.chromium.org/2767113003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/SelectorQuery.cpp:238: // this method finds
that the selectors won't match any element.
This comment was ancient, from when we used to return the traverse roots and
some bools. The code doesn't work this way at all anymore so I removed it.

[sashab, 2017-03-23 05:40:21]

https://codereview.chromium.org/2767113003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/SelectorQuery.cpp (left):

https://codereview.chromium.org/2767113003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/SelectorQuery.cpp:238: // this method finds
that the selectors won't match any element.
On 2017/03/23 at 01:09:33, esprehn wrote:
> This comment was ancient, from when we used to return the traverse roots and
some bools. The code doesn't work this way at all anymore so I removed it.

Wanna add an updated comment to explain how it works now? :)

[esprehn, 2017-03-23 05:48:51]

:)

https://codereview.chromium.org/2767113003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/SelectorQuery.cpp (left):

https://codereview.chromium.org/2767113003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/SelectorQuery.cpp:238: // this method finds
that the selectors won't match any element.
On 2017/03/23 at 05:40:21, sashab wrote:
> On 2017/03/23 at 01:09:33, esprehn wrote:
> > This comment was ancient, from when we used to return the traverse roots and
some bools. The code doesn't work this way at all anymore so I removed it.
> 
> Wanna add an updated comment to explain how it works now? :)

I'd prefer to do that in a separate patch.

[sashab, 2017-03-23 06:26:32]

lgtm

https://codereview.chromium.org/2767113003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/SelectorQuery.cpp (right):

https://codereview.chromium.org/2767113003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/SelectorQuery.cpp:260:
SelectorQueryTrait::appendElement(output, *element);
I don't really understand this part of the change, and why its equivalent to the
existing call to executeForTraverseRoot, but I'm assuming you do :)

[esprehn, 2017-03-23 06:31:58]

https://codereview.chromium.org/2767113003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/SelectorQuery.cpp (right):

https://codereview.chromium.org/2767113003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/SelectorQuery.cpp:260:
SelectorQueryTrait::appendElement(output, *element);
On 2017/03/23 at 06:26:32, sashab wrote:
> I don't really understand this part of the change, and why its equivalent to
the existing call to executeForTraverseRoot, but I'm assuming you do :)

The code used to pass MatchedTraverseRoot as the enum value, which then went
down this branch:

  if (!traverseRoot)
    return;
  if (matchTraverseRoot) {
    if (selectorMatches(selector, toElement(*traverseRoot), rootNode))
      SelectorQueryTrait::appendElement(output, toElement(*traverseRoot));
    return;
  }

I inlined that code here.

[esprehn, 2017-03-23 06:33:36]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2017-03-23 06:33:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 06:37:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490250816385020, "parent_rev":
"1ccd33f53b1c52f9afc2df087a0f608c13bc6bb5", "commit_rev":
"26d67176f9cf8b10fd2a378cb83492e432af23ba"}

[commit-bot: I haz the power, 2017-03-23 06:39:09]

Description was changed from

==========
Simplify some arguments inside SelectorQuery.

We can hoist some code and remove some arguments since we always pass the same
thing.

BUG=703900
==========

to

==========
Simplify some arguments inside SelectorQuery.

We can hoist some code and remove some arguments since we always pass the same
thing.

BUG=703900

Review-Url: https://codereview.chromium.org/2767113003
Cr-Commit-Position: refs/heads/master@{#459011}
Committed:
https://chromium.googlesource.com/chromium/src/+/26d67176f9cf8b10fd2a378cb834...
==========

[commit-bot: I haz the power, 2017-03-23 06:39:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/26d67176f9cf8b10fd2a378cb834...

[sashab, 2017-03-23 23:19:05]

https://codereview.chromium.org/2767113003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/SelectorQuery.cpp (right):

https://codereview.chromium.org/2767113003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/SelectorQuery.cpp:260:
SelectorQueryTrait::appendElement(output, *element);
On 2017/03/23 at 06:31:58, esprehn wrote:
> On 2017/03/23 at 06:26:32, sashab wrote:
> > I don't really understand this part of the change, and why its equivalent to
the existing call to executeForTraverseRoot, but I'm assuming you do :)
> 
> The code used to pass MatchedTraverseRoot as the enum value, which then went
down this branch:
> 
>   if (!traverseRoot)
>     return;
>   if (matchTraverseRoot) {
>     if (selectorMatches(selector, toElement(*traverseRoot), rootNode))
>       SelectorQueryTrait::appendElement(output, toElement(*traverseRoot));
>     return;
>   }
> 
> I inlined that code here.

Can you remove it from the function then? Do other callsites still need it?

[esprehn, 2017-03-24 00:02:31]

https://codereview.chromium.org/2767113003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/SelectorQuery.cpp (right):

https://codereview.chromium.org/2767113003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/SelectorQuery.cpp:260:
SelectorQueryTrait::appendElement(output, *element);
On 2017/03/23 at 23:19:05, sashab wrote:
> ...
> 
> Can you remove it from the function then? Do other callsites still need it?

I did remove it from that function. There's a another function that's similarly
named: executeForTraverseRoots <-- plural with the "s" that still uses it
though.