Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2767103004: Makes InputMethodMus deal correctly with focus changes (Closed)

Created:
3 years, 9 months ago by sky
Modified:
3 years, 9 months ago
Reviewers:
Hadi
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes InputMethodMus deal correctly with focus changes Calling DispatchKeyEventPostIME() may lead to changing the focused text client, which means AckPendingCallbacksUnhandled() may be called. If AckPendingCallbacksUnhandled() is called pending_callbacks_ is cleared. ProcessKeyEventCallback() should remove the callback from the list, then call DispatchKeyEventPostIME() so that it doesn't matter if the focus changes. BUG=none TEST=covered by test R=moshayedi@chromium.org Review-Url: https://codereview.chromium.org/2767103004 Cr-Commit-Position: refs/heads/master@{#459109} Committed: https://chromium.googlesource.com/chromium/src/+/ae34d020eb0cb8d4ea748151470ce031df6f8366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -4 lines) Patch
M ui/aura/mus/input_method_mus.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M ui/aura/mus/input_method_mus_unittest.cc View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
sky
3 years, 9 months ago (2017-03-22 23:45:59 UTC) #1
Hadi
lgtm.
3 years, 9 months ago (2017-03-23 13:42:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767103004/1
3 years, 9 months ago (2017-03-23 16:20:48 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 16:26:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae34d020eb0cb8d4ea748151470c...

Powered by Google App Engine
This is Rietveld 408576698