Issue 2767103003: Fix #29130: only consider classes allocated with generative constructors as potential closures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2767103003: Fix #29130: only consider classes allocated with generative constructors as potential closures (Closed)

Created:
3 years, 9 months ago by Siggi Cherem (dart-lang)

Modified:
3 years, 9 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix #29130: only consider classes allocated with generative constructors as potential closures BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/585829f7557336b76292f66e66a3db4619b69e8e

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -2 lines)			Patch
	M	pkg/compiler/lib/src/inferrer/inferrer_engine.dart	View		2 chunks	+5 lines, -2 lines	0 comments	Download
	A	tests/compiler/dart2js_extra/29130_test.dart	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Total messages: 6 (3 generated)

Siggi Cherem (dart-lang)

3 years, 9 months ago (2017-03-22 23:03:50 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as
585829f7557336b76292f66e66a3db4619b69e8e (presubmit successful).