Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: tests/compiler/dart2js_extra/29130_test.dart

Issue 2767103003: Fix #29130: only consider classes allocated with generative constructors as potential closures (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/inferrer/inferrer_engine.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js_extra/29130_test.dart
diff --git a/tests/compiler/dart2js_extra/29130_test.dart b/tests/compiler/dart2js_extra/29130_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..e4daa3410766c953bd99ce1c6ad9cfadb037637e
--- /dev/null
+++ b/tests/compiler/dart2js_extra/29130_test.dart
@@ -0,0 +1,31 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+/// This is a regression test from issue #29310. The global type-inferrer does
+/// tracing of closures including allocated classes that implement a `call`
+/// method. We incorrectly considered also classes with invoked factory
+/// constructors, even if those were only abstract interfaces or mixins that
+/// weren't actually allocated explicitly.
+library regression_29130;
+
+main() {
+ new B();
+ new C();
+}
+
+class A {
+ call() {}
+}
+
+// interface scenario: we shouldn't trace B
+abstract class B implements A {
+ factory B() => null;
+}
+
+// mixin scenario: we should trace C, but we should trace _C
+abstract class C implements A {
+ factory C() => new D();
+}
+
+class D = A with C;
« no previous file with comments | « pkg/compiler/lib/src/inferrer/inferrer_engine.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698