Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2767093002: Fix AutoplayUmaHelper when autoplay is initiated from multiple sources (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 9 months ago
Reviewers:
whywhat, jwd
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, mlamouri (slow - plz ping)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix AutoplayUmaHelper when autoplay is initiated from multiple sources This CL makes AutoplayUmaHelper to handle the case where the page autoplays by both attribute and play() method. Therefore we can avoid counting the metrics into the wrong bucket. BUG=699176 Review-Url: https://codereview.chromium.org/2767093002 Cr-Commit-Position: refs/heads/master@{#459215} Committed: https://chromium.googlesource.com/chromium/src/+/3d3dfcd34e38fcecaa1ff14bcd12cbc98259f36c

Patch Set 1 #

Patch Set 2 : fixed rappor #

Patch Set 3 : fixed build #

Patch Set 4 : fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -29 lines) Patch
M third_party/WebKit/Source/core/html/AutoplayUmaHelper.h View 3 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp View 1 2 6 chunks +39 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayUmaHelperTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/rappor/rappor.xml View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (14 generated)
Zhiqiang Zhang (Slow)
3 years, 9 months ago (2017-03-22 17:26:23 UTC) #2
whywhat
lgtm
3 years, 9 months ago (2017-03-22 21:13:19 UTC) #3
Zhiqiang Zhang (Slow)
+jwd: histograms.xml
3 years, 9 months ago (2017-03-22 21:14:46 UTC) #5
jwd
lgtm
3 years, 9 months ago (2017-03-23 14:38:56 UTC) #6
Zhiqiang Zhang (Slow)
+mlamouri FYI This CL should not change much, but we should be counting in the ...
3 years, 9 months ago (2017-03-23 15:12:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767093002/20001
3 years, 9 months ago (2017-03-23 15:16:14 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/413264)
3 years, 9 months ago (2017-03-23 15:26:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767093002/40001
3 years, 9 months ago (2017-03-23 17:20:37 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/373418)
3 years, 9 months ago (2017-03-23 17:36:06 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767093002/40001
3 years, 9 months ago (2017-03-23 18:31:02 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/415214)
3 years, 9 months ago (2017-03-23 18:58:31 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767093002/60001
3 years, 9 months ago (2017-03-23 19:13:57 UTC) #24
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 21:07:56 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3d3dfcd34e38fcecaa1ff14bcd12...

Powered by Google App Engine
This is Rietveld 408576698