Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2766913002: Init shelf browser item status and re-enable test. (Closed)

Created:
3 years, 9 months ago by msw
Modified:
3 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Init shelf browser item status and re-enable test. Call UpdateBrowserItemState on BrowserShortcutLauncherItemController creation. (this initializes the status of the shelf's browser item on creation) Enable the previously flaky test (relied on DidFinishNavigation notice) BUG=693341 TEST=Automated test passes reliably R=sky@chromium.org Review-Url: https://codereview.chromium.org/2766913002 Cr-Commit-Position: refs/heads/master@{#458604} Committed: https://chromium.googlesource.com/chromium/src/+/e350b397d2bbe19303903e925de460865541063f

Patch Set 1 #

Patch Set 2 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
msw
Hey Scott, please take a look; thanks!
3 years, 9 months ago (2017-03-21 22:25:34 UTC) #4
sky
LGTM
3 years, 9 months ago (2017-03-21 22:50:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766913002/20001
3 years, 9 months ago (2017-03-21 23:17:20 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 23:44:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e350b397d2bbe19303903e925de4...

Powered by Google App Engine
This is Rietveld 408576698