third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py - Issue 2766823003: Fix testharness result parsing, make "Harness error" count as failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py

Issue 2766823003: Fix testharness result parsing, make "Harness error" count as failure. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py

index 8407b1d877a7ec8c49c4a3bd747139980af6e537..6102e3e38dcd3d78ce9907ba49aa6e075f9abb8c 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py

@@ -53,7 +53,7 @@ def is_testharness_output_passing(content_text):

if (line.startswith('FAIL') or

line.startswith('TIMEOUT') or

line.startswith('NOTRUN') or

- line.startswith('Harness Error. harness_status = ')):

qyearsley 2017/03/21 22:18:11 This turned out to be a very minor error. This was

+ line.startswith('Harness Error.')):

return False

return at_least_one_pass

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py » ('j') | no next file with comments »