Fix testharness result parsing, make "Harness error" count as failure.

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utility module for checking testharness test output."""
 
 _TESTHARNESSREPORT_HEADER = 'This is a testharness.js-based test.'
 _TESTHARNESSREPORT_FOOTER = 'Harness: the test ran to completion.'
 
 
@@ skipping 35 matching lines @@
 
     at_least_one_pass = False
 
     for line in lines:
         if line.startswith('PASS'):
             at_least_one_pass = True
             continue
         if (line.startswith('FAIL') or
                 line.startswith('TIMEOUT') or
                 line.startswith('NOTRUN') or
-                line.startswith('Harness Error. harness_status = ')):

[qyearsley, 2017/03/21 22:18:11]

This turned out to be a very minor error. This was looking for "harness_status",
but in reality when there is a harness error it appears to actually say
"harness_status.status"...

+                line.startswith('Harness Error.')):
             return False
 
     return at_least_one_pass
 
 
 def has_console_errors_or_warnings(content_text):
     """Returns whether |content_text| is has console errors or warnings."""
 
     def is_warning_or_error(line):
         return line.startswith('CONSOLE ERROR:') or line.startswith('CONSOLE WARNING:')
 
     lines = content_text.strip().splitlines()
     return any(is_warning_or_error(line) for line in lines)