Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2766793002: Revert of android: Move launcher_android.cc to helper (Closed)

Created:
3 years, 9 months ago by johnme
Modified:
3 years, 9 months ago
Reviewers:
Jay Civelli, boliu
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of android: Move launcher_android.cc to helper (patchset #1 id:1 of https://codereview.chromium.org/2753383002/ ) Reason for revert: Tentative revert to fix the following DCHECK failure: [FATAL:test_launcher.cc(487)] Check failed: !g_launcher_delegate. in many tests (e.g. content_browsertests) on chromium.android:Lollipop Tablet Tester and KitKat Tablet Tester See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&builder=chromium.android%3ALollipop%20Tablet%20Tester It seems the main function of the test processes is getting called more than once, and this and https://codereview.chromium.org/2753713002 are the only likely culprits in crrev.com/458066..458116 Original issue's description: > android: Move launcher_android.cc to helper > > The ultimate goal is to fix leaking mManagedConnections in > BindingManagerImpl, which is leaking to support getting isOomProtected > after a service has been disconnected. That requires saving that status > in native when service is disconnected, which probably belongs on > LauncherHelper. That implies Helper should talk directly java, and this > is the first step. > > This is meant to to be a straight-forward move with no changes, even if > the existing code makes no sense once they live in the same file. Order > of function is rearranged a bit though. > > BUG=689758 > > Review-Url: https://codereview.chromium.org/2753383002 > Cr-Commit-Position: refs/heads/master@{#458114} > Committed: https://chromium.googlesource.com/chromium/src/+/4ac59a56d54826dbdfc5b17b2e8875863065b0b8 TBR=jcivelli@chromium.org,boliu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=689758

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -161 lines) Patch
M content/browser/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 2 chunks +1 line, -1 line 0 comments Download
A content/browser/android/child_process_launcher_android.h View 1 chunk +44 lines, -0 lines 0 comments Download
A content/browser/android/child_process_launcher_android.cc View 1 chunk +160 lines, -0 lines 0 comments Download
D content/browser/child_process_launcher_helper_android.h View 1 chunk +0 lines, -16 lines 0 comments Download
M content/browser/child_process_launcher_helper_android.cc View 3 chunks +2 lines, -143 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
johnme
Created Revert of android: Move launcher_android.cc to helper
3 years, 9 months ago (2017-03-21 16:17:24 UTC) #2
johnme
3 years, 9 months ago (2017-03-23 11:57:42 UTC) #5
Message was sent while issue was closed.
Abandoning revert. Doesn't seem to be caused by this patch.
https://crbug.com/703708 is attempting to track down the true cause.

Powered by Google App Engine
This is Rietveld 408576698