android: Move launcher_android.cc to helper

android: Move launcher_android.cc to helper

The ultimate goal is to fix leaking mManagedConnections in
BindingManagerImpl, which is leaking to support getting isOomProtected
after a service has been disconnected. That requires saving that status
in native when service is disconnected, which probably belongs on
LauncherHelper. That implies Helper should talk directly java, and this
is the first step.

This is meant to to be a straight-forward move with no changes, even if
the existing code makes no sense once they live in the same file. Order
of function is rearranged a bit though.

BUG=689758
Review-Url: https://codereview.chromium.org/2753383002
Cr-Commit-Position: refs/heads/master@{#458114}
Committed: https://chromium.googlesource.com/chromium/src/+/4ac59a56d54826dbdfc5b17b2e8875863065b0b8

[boliu, 2017-03-18 00:07:18]

boliu@chromium.org changed reviewers:
+ jcivelli@chromium.org

[boliu, 2017-03-18 00:07:19]

ptal

[boliu, 2017-03-18 00:40:40]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-18 00:41:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 02:20:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 02:20:15]

Dry run: This issue passed the CQ dry run.

[Jay Civelli, 2017-03-20 16:44:55]

lgtm

[boliu, 2017-03-20 16:47:01]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2017-03-20 16:47:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 17:45:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490028421430550, "parent_rev":
"4832979ab80769a47bcd70b3a5510d9b523f2b06", "commit_rev":
"4ac59a56d54826dbdfc5b17b2e8875863065b0b8"}

[commit-bot: I haz the power, 2017-03-20 17:46:25]

Description was changed from

==========
android: Move launcher_android.cc to helper

The ultimate goal is to fix leaking mManagedConnections in
BindingManagerImpl, which is leaking to support getting isOomProtected
after a service has been disconnected. That requires saving that status
in native when service is disconnected, which probably belongs on
LauncherHelper. That implies Helper should talk directly java, and this
is the first step.

This is meant to to be a straight-forward move with no changes, even if
the existing code makes no sense once they live in the same file. Order
of function is rearranged a bit though.

BUG=689758
==========

to

==========
android: Move launcher_android.cc to helper

The ultimate goal is to fix leaking mManagedConnections in
BindingManagerImpl, which is leaking to support getting isOomProtected
after a service has been disconnected. That requires saving that status
in native when service is disconnected, which probably belongs on
LauncherHelper. That implies Helper should talk directly java, and this
is the first step.

This is meant to to be a straight-forward move with no changes, even if
the existing code makes no sense once they live in the same file. Order
of function is rearranged a bit though.

BUG=689758

Review-Url: https://codereview.chromium.org/2753383002
Cr-Commit-Position: refs/heads/master@{#458114}
Committed:
https://chromium.googlesource.com/chromium/src/+/4ac59a56d54826dbdfc5b17b2e88...
==========

[commit-bot: I haz the power, 2017-03-20 17:46:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ac59a56d54826dbdfc5b17b2e88...

[johnme, 2017-03-21 16:17:24]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2766793002/ by johnme@chromium.org.

The reason for reverting is: Tentative revert to fix the following DCHECK
failure:
[FATAL:test_launcher.cc(487)] Check failed: !g_launcher_delegate.
in many tests (e.g. content_browsertests) on chromium.android:Lollipop Tablet
Tester and KitKat Tablet Tester

See
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType...

It seems the main function of the test processes is getting called more than
once, and this and https://codereview.chromium.org/2753713002 are the only
likely culprits in crrev.com/458066..458116.