Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2766773002: Fix Views overlay scrollbar border stroke. (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Views overlay scrollbar border stroke. Using a square end cap instead of "butt" makes the stroke extend by a half stroke width (0.5dp or 1px @2x) at the ends. BUG=702744 Review-Url: https://codereview.chromium.org/2766773002 Cr-Commit-Position: refs/heads/master@{#458493} Committed: https://chromium.googlesource.com/chromium/src/+/c6359868104299cc1eb5fe2700a792d52ecaac6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/controls/scrollbar/overlay_scroll_bar.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Evan Stade
3 years, 9 months ago (2017-03-21 15:56:58 UTC) #2
sadrul
lgtm
3 years, 9 months ago (2017-03-21 17:22:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766773002/1
3 years, 9 months ago (2017-03-21 17:33:07 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 18:54:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c6359868104299cc1eb5fe2700a7...

Powered by Google App Engine
This is Rietveld 408576698