Fix DCHECK in ipc_perftests

Fix DCHECK in ipc_perftests

Mojo Channel perf tests use an EDK supplied helper for multiprocess
client setup. This helper assumes ownership of the client's
primordial message pipe. IPC perf tests take ownership of the pipe
and pass it to an IPC::Channel. These are conflicting policies.

This allows a test helper user to indicate that the helper code should
not assume ownership of its pipe handle.

BUG=677202
R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2766763002
Cr-Commit-Position: refs/heads/master@{#458497}
Committed: https://chromium.googlesource.com/chromium/src/+/40e95910df7d53d209041164ebb91351890e9117

[Ken Rockot(use gerrit already), 2017-03-21 15:54:18]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 15:54:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-03-21 16:26:16]

PTAL, just a small test fix that I had forgotten about. Clearing out some old
bugs.

[yzshen1, 2017-03-21 16:43:30]

LGTM with one nit

https://codereview.chromium.org/2766763002/diff/1/mojo/edk/test/multiprocess_...
File mojo/edk/test/multiprocess_test_helper.h (right):

https://codereview.chromium.org/2766763002/diff/1/mojo/edk/test/multiprocess_...
mojo/edk/test/multiprocess_test_helper.h:89: bool close_pipe_on_exit = true);
nit: without reading the code, I am not sure who is responsible to close the
pipe, is it |main| or RunClientMain()? Does it make sense to change
|close_pipe_on_exit| to something like |passes_ownership_to_main|?

[Ken Rockot(use gerrit already), 2017-03-21 16:49:51]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 16:50:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-03-21 16:50:16]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 16:50:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-03-21 16:51:17]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-03-21 16:51:31]

https://codereview.chromium.org/2766763002/diff/1/mojo/edk/test/multiprocess_...
File mojo/edk/test/multiprocess_test_helper.h (right):

https://codereview.chromium.org/2766763002/diff/1/mojo/edk/test/multiprocess_...
mojo/edk/test/multiprocess_test_helper.h:89: bool close_pipe_on_exit = true);
On 2017/03/21 at 16:43:30, yzshen1 wrote:
> nit: without reading the code, I am not sure who is responsible to close the
pipe, is it |main| or RunClientMain()? Does it make sense to change
|close_pipe_on_exit| to something like |passes_ownership_to_main|?

Good point. I've changed it to pass_pipe_ownership_to_main and inverted the
usage.

[Ken Rockot(use gerrit already), 2017-03-21 16:51:34]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-03-21 16:51:34]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2766763002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2017-03-21 16:52:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 18:59:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490115094305780,
"parent_rev": "0f1cedecb0e3586a32ed44d5064f82ff8f8eac5f", "commit_rev":
"40e95910df7d53d209041164ebb91351890e9117"}

[commit-bot: I haz the power, 2017-03-21 19:00:28]

Description was changed from

==========
Fix DCHECK in ipc_perftests

Mojo Channel perf tests use an EDK supplied helper for multiprocess
client setup. This helper assumes ownership of the client's
primordial message pipe. IPC perf tests take ownership of the pipe
and pass it to an IPC::Channel. These are conflicting policies.

This allows a test helper user to indicate that the helper code should
not assume ownership of its pipe handle.

BUG=677202
R=yzshen@chromium.org
==========

to

==========
Fix DCHECK in ipc_perftests

Mojo Channel perf tests use an EDK supplied helper for multiprocess
client setup. This helper assumes ownership of the client's
primordial message pipe. IPC perf tests take ownership of the pipe
and pass it to an IPC::Channel. These are conflicting policies.

This allows a test helper user to indicate that the helper code should
not assume ownership of its pipe handle.

BUG=677202
R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2766763002
Cr-Commit-Position: refs/heads/master@{#458497}
Committed:
https://chromium.googlesource.com/chromium/src/+/40e95910df7d53d209041164ebb9...
==========

[commit-bot: I haz the power, 2017-03-21 19:00:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/40e95910df7d53d209041164ebb9...