Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2766723002: Migrate WTF::Vector::prepend() to ::push_front() (Closed)

Created:
3 years, 9 months ago by pilgrim_google
Modified:
3 years, 9 months ago
CC:
aboxhall+watch_chromium.org, aboxhall, ajuma+watch_chromium.org, darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-wtf_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dmazzoni, dmazzoni+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, dtseng+watch_chromium.org, eae+blinkwatch, Eric Willigers, fmalita+watch_chromium.org, jbroman, jchaffraix+rendering, je_julie, Justin Novosad, kinuko+watch, leviw+renderwatch, Mikhail, nektar+watch_chromium.org, nektarios, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, szager+layoutwatch_chromium.org, yuzo+watch_chromium.org, zoltan1, jsbell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Vector::prepend() to ::push_front() As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2766723002 Cr-Commit-Position: refs/heads/master@{#458510} Committed: https://chromium.googlesource.com/chromium/src/+/26bacca94de2164ff021d1a091cb8cb41632636a

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
pilgrim_google
3 years, 9 months ago (2017-03-21 14:45:20 UTC) #2
haraken
LGTM
3 years, 9 months ago (2017-03-21 15:09:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766723002/1
3 years, 9 months ago (2017-03-21 19:21:42 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 19:33:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/26bacca94de2164ff021d1a091cb...

Powered by Google App Engine
This is Rietveld 408576698