Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2766713002: Add "Read Later" action to ContentSuggestions' context menu (Closed)

Created:
3 years, 9 months ago by gambard
Modified:
3 years, 9 months ago
Reviewers:
Olivier
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "Read Later" action to ContentSuggestions' context menu This CL adds a Read Later action to the context menu display when long pressing on a Suggested article, adding the item to the Reading List. BUG=703634 Review-Url: https://codereview.chromium.org/2766713002 Cr-Commit-Position: refs/heads/master@{#459171} Committed: https://chromium.googlesource.com/chromium/src/+/4471c719a747df355c9adfde31236085076ee954

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add Reading List guards #

Patch Set 3 : Rebase #

Patch Set 4 : Removing guards #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M ios/chrome/browser/content_suggestions/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm View 1 2 3 3 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
gambard
PTAL.
3 years, 9 months ago (2017-03-21 13:53:19 UTC) #2
Olivier
LGTM https://codereview.chromium.org/2766713002/diff/1/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm File ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm (right): https://codereview.chromium.org/2766713002/diff/1/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm#newcode166 ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm:166: NSString* readLaterTitle = if (reading_list::switches::IsReadingListEnabled()) {
3 years, 9 months ago (2017-03-22 08:28:43 UTC) #3
gambard
Thanks! https://codereview.chromium.org/2766713002/diff/1/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm File ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm (right): https://codereview.chromium.org/2766713002/diff/1/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm#newcode166 ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm:166: NSString* readLaterTitle = On 2017/03/22 08:28:43, Olivier Robin ...
3 years, 9 months ago (2017-03-22 08:37:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766713002/20001
3 years, 9 months ago (2017-03-22 08:38:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/177284)
3 years, 9 months ago (2017-03-22 08:46:38 UTC) #9
gambard
I have removed the Reading List guards as I am removing them everywhere in ios/
3 years, 9 months ago (2017-03-23 15:37:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766713002/60001
3 years, 9 months ago (2017-03-23 17:46:16 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 19:20:23 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4471c719a747df355c9adfde3123...

Powered by Google App Engine
This is Rietveld 408576698