Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2766673003: Remove checked-in .isolate files. (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, vmpstr+watch_chromium.org, net-reviews_chromium.org, mikecase+watch_chromium.org, agrieve+watch_chromium.org, jbudorick+watch_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove checked-in .isolate files. If anyone still needs them, please tell me about your use case (and feel free to revert). Ran `git ls-files -- '*.isolate' | xargs git rm` BUG=703799 NOTRY=true TBR=jochen,davidben Review-Url: https://codereview.chromium.org/2766673003 Cr-Commit-Position: refs/heads/master@{#458595} Committed: https://chromium.googlesource.com/chromium/src/+/f526c497b9eae3805d18f71c1cefdf88cfaf8ab5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -597 lines) Patch
D base/base.isolate View 1 chunk +0 lines, -60 lines 0 comments Download
D build/android/android.isolate View 1 chunk +0 lines, -28 lines 0 comments Download
D build/config/win/msvs_dependencies.isolate View 1 chunk +0 lines, -179 lines 0 comments Download
D chrome/breakpad.isolate View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/cdb.isolate View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/chrome.isolate View 1 chunk +0 lines, -135 lines 0 comments Download
D chrome/ct_skps.isolate View 1 chunk +0 lines, -28 lines 0 comments Download
D gin/v8.isolate View 1 chunk +0 lines, -15 lines 0 comments Download
D net/net.isolate View 1 chunk +0 lines, -11 lines 0 comments Download
D net/tools/testserver/testserver.isolate View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/instrumented_libraries/instrumented_libraries.isolate View 1 chunk +0 lines, -22 lines 0 comments Download
D tools/perf/chrome_telemetry_build/telemetry_binary_manager.isolate View 1 chunk +0 lines, -15 lines 0 comments Download
D tools/perf/perf.isolate View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gl/gl.isolate View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 33 (19 generated)
Nico
What could go wrong!
3 years, 9 months ago (2017-03-21 21:45:49 UTC) #6
scottmg
sure-why-not lgtm +maruel for fyi/cancel/panic
3 years, 9 months ago (2017-03-21 21:56:26 UTC) #8
scottmg
On 2017/03/21 21:56:26, scottmg wrote: > sure-why-not lgtm > > +maruel for fyi/cancel/panic doh! parsing ...
3 years, 9 months ago (2017-03-21 21:56:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766673003/1
3 years, 9 months ago (2017-03-21 21:59:01 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/390793)
3 years, 9 months ago (2017-03-21 22:07:24 UTC) #14
Nico
tbr: jochen for gin davidben for net
3 years, 9 months ago (2017-03-21 22:11:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766673003/1
3 years, 9 months ago (2017-03-21 22:12:12 UTC) #19
davidben
net lgtm
3 years, 9 months ago (2017-03-21 22:14:55 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/344776)
3 years, 9 months ago (2017-03-21 22:43:19 UTC) #22
Nico
On 2017/03/21 22:43:19, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 9 months ago (2017-03-21 22:44:36 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766673003/1
3 years, 9 months ago (2017-03-21 22:45:19 UTC) #25
scottmg
On 2017/03/21 22:44:36, Nico wrote: > On 2017/03/21 22:43:19, commit-bot: I haz the power wrote: ...
3 years, 9 months ago (2017-03-21 22:45:32 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766673003/1
3 years, 9 months ago (2017-03-21 22:59:04 UTC) #30
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 23:06:35 UTC) #33
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f526c497b9eae3805d18f71c1cef...

Powered by Google App Engine
This is Rietveld 408576698