Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2766623002: Revert of Fix free memory calculation. (Closed)

Created:
3 years, 9 months ago by horo
Modified:
3 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, vmpstr+watch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, mac-reviews_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org, jinzhang1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix free memory calculation. (patchset #27 id:520001 of https://codereview.chromium.org/2558043007/ ) Reason for revert: SysInfoTest.AmountOfAvailablePhysicalMemory is failing BUG=703522 Original issue's description: > Fix free memory calculation. > > The term "free memory" can mean different things: it can mean > 1) absolutely/pure free physical memory (not consumed by anything) or > 2) it can include the inactive part(s) of OS (file) cache(s) or > 3) it can mean the maximum amount of physical memory that can be > allocated quickly without swapping and thus can also include the > active part(s) of OS cache(s). > > This CL fixes base::AmountOfAvailablePhysicalMemory() to function > according to the 2nd meaning on all platforms where it is possible > because this is what everyone needs most of the time. (Win platform > has already had such implementation but others haven't). > > BUG=672745 > > Review-Url: https://codereview.chromium.org/2558043007 > Cr-Commit-Position: refs/heads/master@{#458291} > Committed: https://chromium.googlesource.com/chromium/src/+/a4258cad75d8cc63170555cc74bd584b5bfca965 TBR=primiano@chromium.org,danakj@chromium.org,brucedawson@chromium.org,xiyuan@chromium.org,chrisha@chromium.org,haraken@chromium.org,mkolom@yandex-team.ru # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672745 Review-Url: https://codereview.chromium.org/2766623002 Cr-Commit-Position: refs/heads/master@{#458333} Committed: https://chromium.googlesource.com/chromium/src/+/ad039f65398a94f4a28751c303df388cff4bbca3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -280 lines) Patch
M base/process/process_metrics.h View 2 chunks +23 lines, -45 lines 0 comments Download
M base/process/process_metrics.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M base/process/process_metrics_ios.cc View 3 chunks +9 lines, -35 lines 0 comments Download
M base/process/process_metrics_linux.cc View 4 chunks +35 lines, -3 lines 0 comments Download
M base/process/process_metrics_mac.cc View 4 chunks +17 lines, -20 lines 0 comments Download
M base/process/process_metrics_unittest.cc View 8 chunks +4 lines, -28 lines 0 comments Download
M base/process/process_metrics_win.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M base/sys_info.h View 3 chunks +0 lines, -19 lines 0 comments Download
M base/sys_info_ios.mm View 2 chunks +12 lines, -6 lines 0 comments Download
M base/sys_info_linux.cc View 2 chunks +4 lines, -21 lines 0 comments Download
M base/sys_info_mac.mm View 2 chunks +13 lines, -6 lines 0 comments Download
M base/sys_info_openbsd.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M base/sys_info_unittest.cc View 8 chunks +46 lines, -74 lines 0 comments Download
M base/sys_info_win.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 2 chunks +1 line, -4 lines 0 comments Download
M components/memory_pressure/direct_memory_pressure_calculator_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/memory_pressure/direct_memory_pressure_calculator_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/memory/memory_monitor_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/memory/memory_monitor_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
horo
Created Revert of Fix free memory calculation.
3 years, 9 months ago (2017-03-21 07:01:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766623002/1
3 years, 9 months ago (2017-03-21 07:02:02 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 07:04:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ad039f65398a94f4a28751c303df...

Powered by Google App Engine
This is Rietveld 408576698