Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: net/quic/chromium/quic_network_transaction_unittest.cc

Issue 2766603004: QUIC: mark QUIC handshake failed if connection is closed after CryptoConnect (Closed)
Patch Set: disable QuicUploadToAlternativeProxyServer Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/quic_network_transaction_unittest.cc
diff --git a/net/quic/chromium/quic_network_transaction_unittest.cc b/net/quic/chromium/quic_network_transaction_unittest.cc
index f38245b7aae6de643814dfec10288cbe77271c98..86a22bf92dbf05324e0468cffd61ca26226c254e 100644
--- a/net/quic/chromium/quic_network_transaction_unittest.cc
+++ b/net/quic/chromium/quic_network_transaction_unittest.cc
@@ -2670,7 +2670,10 @@ TEST_P(QuicNetworkTransactionTest, SecureResourceOverSecureQuic) {
test_socket_performance_watcher_factory_.rtt_notification_received());
}
-TEST_P(QuicNetworkTransactionTest, QuicUploadToAlternativeProxyServer) {
+// TODO(zhongyi): disabled this broken test as it is not testing the correct
+// code path. Need fix.
xunjieli 2017/03/23 16:18:02 Need a bug number here.
Zhongyi Shi 2017/03/23 17:28:50 Done.
+TEST_P(QuicNetworkTransactionTest,
+ DISABLED_QuicUploadToAlternativeProxyServer) {
base::HistogramTester histogram_tester;
proxy_service_ =
ProxyService::CreateFixedFromPacResult("HTTPS mail.example.org:443");

Powered by Google App Engine
This is Rietveld 408576698