Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: net/quic/chromium/quic_chromium_client_session.cc

Issue 2766603004: QUIC: mark QUIC handshake failed if connection is closed after CryptoConnect (Closed)
Patch Set: disable QuicUploadToAlternativeProxyServer Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/quic_chromium_client_session.cc
diff --git a/net/quic/chromium/quic_chromium_client_session.cc b/net/quic/chromium/quic_chromium_client_session.cc
index d783551a80145c58032a9ce31a09b2446bc0f9d6..115faac314756485c856c235b891ffc6b65931ef 100644
--- a/net/quic/chromium/quic_chromium_client_session.cc
+++ b/net/quic/chromium/quic_chromium_client_session.cc
@@ -670,6 +670,9 @@ int QuicChromiumClientSession::CryptoConnect(
DCHECK(flow_controller());
crypto_stream_->CryptoConnect();
+ if (!connection()->connected())
xunjieli 2017/03/23 16:18:02 nit: Maybe add a comment here explaining why we ne
Zhongyi Shi 2017/03/23 17:28:50 Done.
+ return ERR_QUIC_HANDSHAKE_FAILED;
+
if (IsCryptoHandshakeConfirmed()) {
connect_timing_.connect_end = base::TimeTicks::Now();
return OK;

Powered by Google App Engine
This is Rietveld 408576698