Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2766603003: MD Settings: Add listeners on attached instead of ready. (Closed)

Created:
3 years, 9 months ago by hcarmona
Modified:
3 years, 9 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Add listeners on attached instead of ready. This prevents a visual glitch where you can see the top of the settings page before the sub page loads. BUG=702495 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2766603003 Cr-Commit-Position: refs/heads/master@{#458946} Committed: https://chromium.googlesource.com/chromium/src/+/2375ddd498a6ee826fc3ac6edf220b91f41cc615

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (14 generated)
hcarmona
PTAL
3 years, 9 months ago (2017-03-22 20:47:38 UTC) #10
dpapad
lgtm
3 years, 9 months ago (2017-03-22 22:39:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766603003/20001
3 years, 9 months ago (2017-03-23 00:08:01 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 00:17:07 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2375ddd498a6ee826fc3ac6edf22...

Powered by Google App Engine
This is Rietveld 408576698