Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2766603002:
Add breakdown histograms for injected script execution time (Closed)
|
Created:
3 years, 9 months ago by Kunihiko Sakamoto Modified:
3 years, 9 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd breakdown histograms for injected script execution time
Currently we have the following metrics for content script injections:
- Extensions.Inject{Start,End,Idle}_Time: Time to inject all extensions'
scripts for one run_location. Recorded only if injected synchronously.
- Extensions.InjectedScriptExecutionTime: Time to inject one extension's
scripts, not broken down by run_location.
This patch adds breakdown histograms for InjectedScriptExecutionTime by
locations. Also, add notes to Inject{Start,End,Idle}_Time descriptions
that these are reported only for synchronous script injections.
BUG=636655
Review-Url: https://codereview.chromium.org/2766603002
Cr-Commit-Position: refs/heads/master@{#459375}
Committed: https://chromium.googlesource.com/chromium/src/+/049f833eba3d4dedd636728c504f5edcb44d91e0
Patch Set 1 #
Total comments: 2
Patch Set 2 : Use histogram_suffixes #
Total comments: 4
Patch Set 3 : suffix labels #
Messages
Total messages: 22 (12 generated)
The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from
==========
Breakdown histograms
BUG=
==========
to
==========
Add breakdown histograms for injected script execution time
Currently we have the following metrics for content script injections:
- Extensions.Inject{Start,End,Idle}_Time: Time to inject all extensions'
scripts for one run_location. Recorded only if injected synchronously.
- Extensions.InjectedScriptExecutionTime: Time to inject one extension's
scripts, not broken down by run_location.
This patch adds breakdown histograms for InjectedScriptExecutionTime by
locations. Also, add notes to Inject{Start,End,Idle}_Time descriptions
that these are reported only for synchronous script injections.
BUG=636655
==========
ksakamoto@chromium.org changed reviewers: + isherman@chromium.org, rdevlin.cronin@chromium.org
https://codereview.chromium.org/2766603002/diff/1/extensions/renderer/script_... File extensions/renderer/script_injection.cc (right): https://codereview.chromium.org/2766603002/diff/1/extensions/renderer/script_... extensions/renderer/script_injection.cc:330: UMA_HISTOGRAM_TIMES("Extensions.InjectStart_ExecutionTime", elapsed); I'd recommend using a histogram suffix here, and making these, e.g., Extensions.InjectionExecutionTime.DocumentStart, etc.
https://codereview.chromium.org/2766603002/diff/1/extensions/renderer/script_... File extensions/renderer/script_injection.cc (right): https://codereview.chromium.org/2766603002/diff/1/extensions/renderer/script_... extensions/renderer/script_injection.cc:330: UMA_HISTOGRAM_TIMES("Extensions.InjectStart_ExecutionTime", elapsed); On 2017/03/21 20:40:47, Devlin wrote: > I'd recommend using a histogram suffix here, and making these, e.g., > Extensions.InjectionExecutionTime.DocumentStart, etc. Ah I've forgotten about histogram_suffixes. Done, thanks!
lgtm % comment https://codereview.chromium.org/2766603002/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2766603002/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:18602: + Time taken to inject all scripts at document end by extensions. Not reported Is this correct? I thought the histogram would still be emitted, but would only account for the synchronous injection time. If that's the case, maybe something like: // Synchronous time taken to inject all scripts at document end by extensions. If // scripts are injected asynchronously, this does not include the total time for // the script to run. Usually, prefer Extensions.InjectedScriptExecutionTime.
Metrics LGTM % a nit: https://codereview.chromium.org/2766603002/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2766603002/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:123129: + <suffix name="DocumentIdle"/> nit: Please add a brief label for each suffix.
https://codereview.chromium.org/2766603002/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2766603002/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:18602: + Time taken to inject all scripts at document end by extensions. Not reported On 2017/03/22 13:56:06, Devlin wrote: > Is this correct? I thought the histogram would still be emitted, but would only > account for the synchronous injection time. If that's the case, maybe something > like: > // Synchronous time taken to inject all scripts at document end by extensions. > If > // scripts are injected asynchronously, this does not include the total time for > // the script to run. Usually, prefer Extensions.InjectedScriptExecutionTime. This is correct (I checked locally) -- asynchronous injections are counted as |num_blocking_js| in ScriptsRunInfo, and that prevents this histogram from being logged. https://cs.chromium.org/chromium/src/extensions/renderer/scripts_run_info.cc?... https://codereview.chromium.org/2766603002/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:123129: + <suffix name="DocumentIdle"/> On 2017/03/22 22:38:06, Ilya Sherman wrote: > nit: Please add a brief label for each suffix. Done.
The CQ bit was checked by ksakamoto@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rdevlin.cronin@chromium.org, isherman@chromium.org Link to the patchset: https://codereview.chromium.org/2766603002/#ps40001 (title: "suffix labels")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ksakamoto@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490329077122350,
"parent_rev": "f97e9e6a8f622968d0e1914903400df6a2e9d28f", "commit_rev":
"049f833eba3d4dedd636728c504f5edcb44d91e0"}
Message was sent while issue was closed.
Description was changed from
==========
Add breakdown histograms for injected script execution time
Currently we have the following metrics for content script injections:
- Extensions.Inject{Start,End,Idle}_Time: Time to inject all extensions'
scripts for one run_location. Recorded only if injected synchronously.
- Extensions.InjectedScriptExecutionTime: Time to inject one extension's
scripts, not broken down by run_location.
This patch adds breakdown histograms for InjectedScriptExecutionTime by
locations. Also, add notes to Inject{Start,End,Idle}_Time descriptions
that these are reported only for synchronous script injections.
BUG=636655
==========
to
==========
Add breakdown histograms for injected script execution time
Currently we have the following metrics for content script injections:
- Extensions.Inject{Start,End,Idle}_Time: Time to inject all extensions'
scripts for one run_location. Recorded only if injected synchronously.
- Extensions.InjectedScriptExecutionTime: Time to inject one extension's
scripts, not broken down by run_location.
This patch adds breakdown histograms for InjectedScriptExecutionTime by
locations. Also, add notes to Inject{Start,End,Idle}_Time descriptions
that these are reported only for synchronous script injections.
BUG=636655
Review-Url: https://codereview.chromium.org/2766603002
Cr-Commit-Position: refs/heads/master@{#459375}
Committed:
https://chromium.googlesource.com/chromium/src/+/049f833eba3d4dedd636728c504f...
==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/049f833eba3d4dedd636728c504f... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
