WebVR: clear screen after submit if preserveDrawingBuffer is false.

WebVR: clear screen after submit if preserveDrawingBuffer is false.

That's part of the spec, normally compositing does so but that's
paused while presenting.

BUG=703378
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2766553004
Cr-Commit-Position: refs/heads/master@{#458648}
Committed: https://chromium.googlesource.com/chromium/src/+/e214268ec8e017ccaafe1dda4dca58015456f7a9

[klausw, 2017-03-21 19:32:25]

Description was changed from

==========
WebVR: clear screen after submit if preserveDrawingBuffer is false.

That's part of the spec, normally compositing does so but that's
paused while presenting.

BUG=703378
==========

to

==========
WebVR: clear screen after submit if preserveDrawingBuffer is false.

That's part of the spec, normally compositing does so but that's
paused while presenting.

BUG=703378
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[klausw, 2017-03-21 19:32:41]

klausw@chromium.org changed reviewers:
+ bajones@chromium.org

[klausw, 2017-03-21 19:38:04]

The CQ bit was checked by klausw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 19:38:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bajones, 2017-03-21 20:45:45]

On 2017/03/21 19:32:42, klausw wrote:

LGTM with one nit: The name doesn't seem appropriately descriptive. Maybe
something more like "markCompositedAndClearIfNeeded?"

[commit-bot: I haz the power, 2017-03-21 23:10:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 23:10:40]

Dry run: This issue passed the CQ dry run.

[klausw, 2017-03-21 23:28:12]

On 2017/03/21 20:45:45, bajones wrote:
> On 2017/03/21 19:32:42, klausw wrote:
> 
> LGTM with one nit: The name doesn't seem appropriately descriptive. Maybe
> something more like "markCompositedAndClearIfNeeded?"

Done.

[klausw, 2017-03-21 23:28:15]

The CQ bit was checked by klausw@chromium.org

[klausw, 2017-03-21 23:28:16]

The patchset sent to the CQ was uploaded after l-g-t-m from bajones@chromium.org
Link to the patchset: https://codereview.chromium.org/2766553004/#ps20001
(title: "Rename to markCompositedAndClearBackbufferIfNeeded")

[commit-bot: I haz the power, 2017-03-21 23:28:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[klausw, 2017-03-21 23:29:02]

On 2017/03/21 23:28:12, klausw wrote:
> On 2017/03/21 20:45:45, bajones wrote:
> > On 2017/03/21 19:32:42, klausw wrote:
> > 
> > LGTM with one nit: The name doesn't seem appropriately descriptive. Maybe
> > something more like "markCompositedAndClearIfNeeded?"
> 
> Done.

Specifically, I called it markCompositedAndClearBackbufferIfNeeded since it
always acts on the backbuffer even if the app is bound to a different
renderbuffer.

[commit-bot: I haz the power, 2017-03-21 23:39:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 23:40:00]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[klausw, 2017-03-22 01:21:00]

The CQ bit was checked by klausw@chromium.org

[commit-bot: I haz the power, 2017-03-22 01:22:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 01:30:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 01:30:35]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[klausw, 2017-03-22 04:50:01]

The CQ bit was checked by klausw@chromium.org

[commit-bot: I haz the power, 2017-03-22 04:50:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 04:57:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490158201298810,
"parent_rev": "8773b38c48cf8b27ed4dd1c8ca249944929d3d16", "commit_rev":
"95e2a91c51d76bfdd6a6e35369290afc5873fa97"}

[commit-bot: I haz the power, 2017-03-22 05:08:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 05:08:19]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[klausw, 2017-03-22 06:19:50]

The CQ bit was checked by klausw@chromium.org

[commit-bot: I haz the power, 2017-03-22 06:20:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 06:49:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490163590661710,
"parent_rev": "e3cf9093ddcaa466a5cf7153745e37d579679ab7", "commit_rev":
"e214268ec8e017ccaafe1dda4dca58015456f7a9"}

[commit-bot: I haz the power, 2017-03-22 06:50:30]

Description was changed from

==========
WebVR: clear screen after submit if preserveDrawingBuffer is false.

That's part of the spec, normally compositing does so but that's
paused while presenting.

BUG=703378
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
WebVR: clear screen after submit if preserveDrawingBuffer is false.

That's part of the spec, normally compositing does so but that's
paused while presenting.

BUG=703378
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2766553004
Cr-Commit-Position: refs/heads/master@{#458648}
Committed:
https://chromium.googlesource.com/chromium/src/+/e214268ec8e017ccaafe1dda4dca...
==========

[commit-bot: I haz the power, 2017-03-22 06:50:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e214268ec8e017ccaafe1dda4dca...