Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2766543002: Move even more from WmShell to Shell (Closed)

Created:
3 years, 9 months ago by sky
Modified:
3 years, 9 months ago
Reviewers:
James Cook, reveman
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, mlamouri+watch-screen-orientation_chromium.org, hidehiko+watch_chromium.org, yzshen+watch_chromium.org, lhchavez+watch_chromium.org, yhanada+watchvk_chromium.org, michaelpg+watch-md-settings_chromium.org, yusukes+watch_chromium.org, extensions-reviews_chromium.org, jam, abarth-chromium, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, groby+virtualkb_chromium.org, dbeam+watch-options_chromium.org, victorhsieh+watch_chromium.org, derat+watch_chromium.org, dcheng, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, dfaden+virtualkb_google.com, dbeam+watch-settings_chromium.org, elijahtaylor+arcwatch_chromium.org, michaelpg+watch-options_chromium.org, tfarina, shuchen+watch_chromium.org, Aaron Boodman, oka+watchvk_chromium.org, darin (slow to review), stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move even more from WmShell to Shell I don't believe any of these are related, just the next set in alphabetical order. BUG=687660 TEST=covered by tests R=jamescook@chromium.org, reveman@chromium.org TBR=reveman@chromium.org Review-Url: https://codereview.chromium.org/2766543002 Cr-Commit-Position: refs/heads/master@{#458511} Committed: https://chromium.googlesource.com/chromium/src/+/5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -237 lines) Patch
M ash/common/accelerators/accelerator_commands.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/common/accelerators/accelerator_controller.cc View 10 chunks +15 lines, -15 lines 0 comments Download
M ash/common/accelerators/debug_commands.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/common/focus_cycler.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/common/frame/caption_buttons/frame_caption_button_container_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/common/frame/caption_buttons/frame_caption_button_container_view_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/common/frame/custom_frame_view_ash_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/common/metrics/pointer_metrics_recorder.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/common/metrics/pointer_metrics_recorder_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/common/mojo_interface_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/common/shelf/shelf_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/brightness/tray_brightness.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/brightness/tray_brightness_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M ash/common/system/chromeos/media_security/multi_profile_media_tray_item.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/media_security/multi_profile_media_tray_item_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/common/system/overview/overview_button_tray.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/common/system/user/user_card_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/common/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/mru_window_tracker_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/common/wm/overview/window_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/overview/window_selector_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/window_cycle_controller.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ash/common/wm/window_cycle_list.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/wm/window_positioner.h View 3 chunks +1 line, -4 lines 0 comments Download
M ash/common/wm/window_positioner.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M ash/common/wm_shell.h View 4 chunks +0 lines, -28 lines 0 comments Download
M ash/common/wm_shell.cc View 4 chunks +1 line, -25 lines 0 comments Download
M ash/content/display/screen_orientation_controller_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/screen_orientation_controller_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.h View 4 chunks +18 lines, -0 lines 0 comments Download
M ash/shell.cc View 8 chunks +11 lines, -5 lines 0 comments Download
M ash/system/chromeos/power/tablet_power_button_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/power/tablet_power_button_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M ash/system/overview/overview_button_tray_unittest.cc View 6 chunks +12 lines, -11 lines 0 comments Download
M ash/virtual_keyboard_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/virtual_keyboard_controller_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M ash/wm/ash_focus_rules.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/power_button_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos_unittest.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/window_positioner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/exo/wm_helper_ash.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (12 generated)
sky
3 years, 9 months ago (2017-03-21 04:27:40 UTC) #2
James Cook
LGTM
3 years, 9 months ago (2017-03-21 18:25:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766543002/1
3 years, 9 months ago (2017-03-21 19:07:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/390588)
3 years, 9 months ago (2017-03-21 19:22:32 UTC) #11
sky
TBR reveman for trivial exo change
3 years, 9 months ago (2017-03-21 19:24:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766543002/1
3 years, 9 months ago (2017-03-21 19:25:49 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 19:36:28 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ab1647cbaef5a6a8b76e7cb4ce1...

Powered by Google App Engine
This is Rietveld 408576698