Allow creating opaque swapchains in DirectCompositionSurfaceWin

Allow creating opaque swapchains in DirectCompositionSurfaceWin

This saves power in fullscreen mode when the content can't use overlays.

BUG=678800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2766423003
Cr-Commit-Position: refs/heads/master@{#460898}
Committed: https://chromium.googlesource.com/chromium/src/+/40180bf2169993034df22de837da666b4977f2c8

[jbauman, 2017-03-23 01:59:41]

Description was changed from

==========
Allow creating opaque swapchains in DirectCompositionSurfaceWin

This saves power in fullscreen mode when the content can't use overlays.

BUG=678800
==========

to

==========
Allow creating opaque swapchains in DirectCompositionSurfaceWin

This saves power in fullscreen mode when the content can't use overlays.

BUG=678800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2017-03-23 01:59:47]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 02:00:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 02:52:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 02:52:13]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-03-23 02:53:23]

jbauman@chromium.org changed reviewers:
+ sunnyps@chromium.org

[sunnyps, 2017-03-28 22:33:37]

Can you add a test for this? Maybe a test with dc layers disabled and switching
between opaque/non-opaque swap chain?

https://codereview.chromium.org/2766423003/diff/1/gpu/ipc/service/direct_comp...
File gpu/ipc/service/direct_composition_surface_win.cc (right):

https://codereview.chromium.org/2766423003/diff/1/gpu/ipc/service/direct_comp...
gpu/ipc/service/direct_composition_surface_win.cc:283: if (size == GetSize() ||
has_alpha != has_alpha_)
Shouldn't this be " && has_alpha == has_alpha_"?

[jbauman, 2017-03-28 23:14:31]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 23:15:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2017-03-28 23:24:58]

PTAL.

On 2017/03/28 22:33:37, sunnyps wrote:
> Can you add a test for this? Maybe a test with dc layers disabled and
switching
> between opaque/non-opaque swap chain?
>
Done.
 
>
https://codereview.chromium.org/2766423003/diff/1/gpu/ipc/service/direct_comp...
> File gpu/ipc/service/direct_composition_surface_win.cc (right):
> 
>
https://codereview.chromium.org/2766423003/diff/1/gpu/ipc/service/direct_comp...
> gpu/ipc/service/direct_composition_surface_win.cc:283: if (size == GetSize()
||
> has_alpha != has_alpha_)
> Shouldn't this be " && has_alpha == has_alpha_"?

Done.

[sunnyps, 2017-03-28 23:33:30]

lgtm % nit

https://codereview.chromium.org/2766423003/diff/20001/gpu/ipc/service/direct_...
File gpu/ipc/service/direct_composition_surface_win_unittest.cc (right):

https://codereview.chromium.org/2766423003/diff/20001/gpu/ipc/service/direct_...
gpu/ipc/service/direct_composition_surface_win_unittest.cc:234:
ASSERT_TRUE(swap_chain);
nit: Why ASSERT instead of EXPECT here and below?

[jbauman, 2017-03-28 23:40:58]

https://codereview.chromium.org/2766423003/diff/20001/gpu/ipc/service/direct_...
File gpu/ipc/service/direct_composition_surface_win_unittest.cc (right):

https://codereview.chromium.org/2766423003/diff/20001/gpu/ipc/service/direct_...
gpu/ipc/service/direct_composition_surface_win_unittest.cc:234:
ASSERT_TRUE(swap_chain);
On 2017/03/28 23:33:29, sunnyps wrote:
> nit: Why ASSERT instead of EXPECT here and below?

If it's null then swap_chain->GetDesc1 will crash, so we might as well give up
early.

[commit-bot: I haz the power, 2017-03-29 01:11:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:11:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbauman, 2017-03-30 04:40:56]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2017-03-30 04:41:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 04:43:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 04:43:36]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jbauman, 2017-03-30 20:17:49]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2017-03-30 20:17:50]

The patchset sent to the CQ was uploaded after l-g-t-m from sunnyps@chromium.org
Link to the patchset: https://codereview.chromium.org/2766423003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-30 20:19:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 21:52:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490905069811380,
"parent_rev": "68c20537e9ecd5715ffe280091c37fc6aa0a70f6", "commit_rev":
"40180bf2169993034df22de837da666b4977f2c8"}

[commit-bot: I haz the power, 2017-03-30 21:53:52]

Description was changed from

==========
Allow creating opaque swapchains in DirectCompositionSurfaceWin

This saves power in fullscreen mode when the content can't use overlays.

BUG=678800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Allow creating opaque swapchains in DirectCompositionSurfaceWin

This saves power in fullscreen mode when the content can't use overlays.

BUG=678800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2766423003
Cr-Commit-Position: refs/heads/master@{#460898}
Committed:
https://chromium.googlesource.com/chromium/src/+/40180bf2169993034df22de837da...
==========

[commit-bot: I haz the power, 2017-03-30 21:53:53]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/40180bf2169993034df22de837da...