Convert most of the rest of instrumentation tests in content

Convert most of the rest of instrumentation tests in content

For more on JUnit4 migration, check src/testing/android/docs/junit4.md

BUG=640116
Review-Url: https://codereview.chromium.org/2766393004
Cr-Commit-Position: refs/heads/master@{#465379}
Committed: https://chromium.googlesource.com/chromium/src/+/c38c29e5447a9e3b8188dcecd343a7a8533d3d0d

[the real yoland, 2017-03-23 04:02:22]

yolandyan@chromium.org changed reviewers:
+ boliu@chromium.org, jbudorick@chromium.org

[the real yoland, 2017-03-23 04:02:23]

This convert all but 4 tests for content instrumentation tests. As for the rest,
3 of them needs parameterized testing, 1 of them restriction check is failing,
needs more debugging

[the real yoland, 2017-03-23 04:02:34]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 04:02:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 04:18:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 04:18:16]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[boliu, 2017-03-23 18:04:08]

https://codereview.chromium.org/2766393004/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
(left):

https://codereview.chromium.org/2766393004/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java:50:
LibraryLoader.get(LibraryProcessType.PROCESS_CHILD).ensureInitialized();
why not use a @Before method?

[the real yoland, 2017-03-23 18:39:56]

https://codereview.chromium.org/2766393004/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
(left):

https://codereview.chromium.org/2766393004/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java:50:
LibraryLoader.get(LibraryProcessType.PROCESS_CHILD).ensureInitialized();
On 2017/03/23 at 18:04:08, boliu wrote:
> why not use a @Before method?

Because for testServiceFailedToBind, mCommandLineTestRule.setUp() needs to
happen before
`LibraryLoader.get(LibraryProcessType.PROCESS_CHILD).ensureInitialized();`

[boliu, 2017-03-23 18:42:33]

https://codereview.chromium.org/2766393004/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
(left):

https://codereview.chromium.org/2766393004/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java:50:
LibraryLoader.get(LibraryProcessType.PROCESS_CHILD).ensureInitialized();
On 2017/03/23 18:39:56, the real yoland wrote:
> On 2017/03/23 at 18:04:08, boliu wrote:
> > why not use a @Before method?
> 
> Because for testServiceFailedToBind, mCommandLineTestRule.setUp() needs to
> happen before
> `LibraryLoader.get(LibraryProcessType.PROCESS_CHILD).ensureInitialized();`

Does that mean we no longer have per-test command line support?

[the real yoland, 2017-03-23 19:01:03]

https://codereview.chromium.org/2766393004/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
(left):

https://codereview.chromium.org/2766393004/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java:50:
LibraryLoader.get(LibraryProcessType.PROCESS_CHILD).ensureInitialized();
On 2017/03/23 at 18:42:32, boliu wrote:
> On 2017/03/23 18:39:56, the real yoland wrote:
> > On 2017/03/23 at 18:04:08, boliu wrote:
> > > why not use a @Before method?
> > 
> > Because for testServiceFailedToBind, mCommandLineTestRule.setUp() needs to
> > happen before
> > `LibraryLoader.get(LibraryProcessType.PROCESS_CHILD).ensureInitialized();`
> 
> Does that mean we no longer have per-test command line support?

yes

if we want per-test support, we need to use annotation, which is somewhat
confusing when mixed with CommandLineTestRule.

I guess this is sacrifice some support for the sake of clarity.

[boliu, 2017-03-23 19:02:51]

https://codereview.chromium.org/2766393004/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
(left):

https://codereview.chromium.org/2766393004/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java:50:
LibraryLoader.get(LibraryProcessType.PROCESS_CHILD).ensureInitialized();
On 2017/03/23 19:01:03, the real yoland wrote:
> On 2017/03/23 at 18:42:32, boliu wrote:
> > On 2017/03/23 18:39:56, the real yoland wrote:
> > > On 2017/03/23 at 18:04:08, boliu wrote:
> > > > why not use a @Before method?
> > > 
> > > Because for testServiceFailedToBind, mCommandLineTestRule.setUp() needs to
> > > happen before
> > > `LibraryLoader.get(LibraryProcessType.PROCESS_CHILD).ensureInitialized();`
> > 
> > Does that mean we no longer have per-test command line support?
> 
> yes
> 
> if we want per-test support, we need to use annotation, which is somewhat
> confusing when mixed with CommandLineTestRule.
> 
> I guess this is sacrifice some support for the sake of clarity.

If annotation still works, why do we have CommandLineTestRule? Having two ways
to do the same thing is more confusing

[the real yoland, 2017-03-23 19:16:32]

https://codereview.chromium.org/2766393004/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
(left):

https://codereview.chromium.org/2766393004/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java:50:
LibraryLoader.get(LibraryProcessType.PROCESS_CHILD).ensureInitialized();
On 2017/03/23 at 19:02:51, boliu wrote:
> On 2017/03/23 19:01:03, the real yoland wrote:
> > On 2017/03/23 at 18:42:32, boliu wrote:
> > > On 2017/03/23 18:39:56, the real yoland wrote:
> > > > On 2017/03/23 at 18:04:08, boliu wrote:
> > > > > why not use a @Before method?
> > > > 
> > > > Because for testServiceFailedToBind, mCommandLineTestRule.setUp() needs
to
> > > > happen before
> > > >
`LibraryLoader.get(LibraryProcessType.PROCESS_CHILD).ensureInitialized();`
> > > 
> > > Does that mean we no longer have per-test command line support?
> > 
> > yes
> > 
> > if we want per-test support, we need to use annotation, which is somewhat
> > confusing when mixed with CommandLineTestRule.
> > 
> > I guess this is sacrifice some support for the sake of clarity.
> 
> If annotation still works, why do we have CommandLineTestRule? Having two ways
to do the same thing is more confusing

currently, annotation does not work. It would works when there is
CommandLineTestRule, and CommandLineTestRule looks for the annotation (e.g.
CommandLineFlags.Add) and then do something in Rule running process

[boliu, 2017-03-23 20:08:56]

https://codereview.chromium.org/2766393004/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
(left):

https://codereview.chromium.org/2766393004/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java:50:
LibraryLoader.get(LibraryProcessType.PROCESS_CHILD).ensureInitialized();
On 2017/03/23 19:16:31, the real yoland wrote:
> On 2017/03/23 at 19:02:51, boliu wrote:
> > On 2017/03/23 19:01:03, the real yoland wrote:
> > > On 2017/03/23 at 18:42:32, boliu wrote:
> > > > On 2017/03/23 18:39:56, the real yoland wrote:
> > > > > On 2017/03/23 at 18:04:08, boliu wrote:
> > > > > > why not use a @Before method?
> > > > > 
> > > > > Because for testServiceFailedToBind, mCommandLineTestRule.setUp()
needs
> to
> > > > > happen before
> > > > >
> `LibraryLoader.get(LibraryProcessType.PROCESS_CHILD).ensureInitialized();`
> > > > 
> > > > Does that mean we no longer have per-test command line support?
> > > 
> > > yes
> > > 
> > > if we want per-test support, we need to use annotation, which is somewhat
> > > confusing when mixed with CommandLineTestRule.
> > > 
> > > I guess this is sacrifice some support for the sake of clarity.
> > 
> > If annotation still works, why do we have CommandLineTestRule? Having two
ways
> to do the same thing is more confusing
> 
> currently, annotation does not work. It would works when there is
> CommandLineTestRule, and CommandLineTestRule looks for the annotation (e.g.
> CommandLineFlags.Add) and then do something in Rule running process

Can we do that here then?

[the real yoland, 2017-04-03 23:33:39]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 23:34:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[the real yoland, 2017-04-03 23:34:47]

Keep supporting @CommandLineFlags annotations in JUnit4

[the real yoland, 2017-04-03 23:34:55]

yolandyan@chromium.org changed reviewers:
+ mikecase@chromium.org

[jbudorick, 2017-04-04 00:39:56]

This seems ok.

https://codereview.chromium.org/2766393004/diff/40001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeActivityTestRule.java
(right):

https://codereview.chromium.org/2766393004/diff/40001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeActivityTestRule.java:29:
public JavaBridgeActivityTestRule(boolean setUp) {
Should this use https://codereview.chromium.org/2770393002/ once that lands?

https://codereview.chromium.org/2766393004/diff/40001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/input/CursorAnchorInfoControllerTest.java
(right):

https://codereview.chromium.org/2766393004/diff/40001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/input/CursorAnchorInfoControllerTest.java:95:
private static class AssertionHelper {
What's the motivation behind moving these into a private static class?

[commit-bot: I haz the power, 2017-04-04 00:52:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 00:52:10]

Dry run: This issue passed the CQ dry run.

[boliu, 2017-04-04 15:16:42]

lgtm

[the real yoland, 2017-04-04 17:41:26]

https://codereview.chromium.org/2766393004/diff/40001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeActivityTestRule.java
(right):

https://codereview.chromium.org/2766393004/diff/40001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeActivityTestRule.java:29:
public JavaBridgeActivityTestRule(boolean setUp) {
On 2017/04/04 at 00:39:55, jbudorick wrote:
> Should this use https://codereview.chromium.org/2770393002/ once that lands?

Yes, will change to that once it lands

https://codereview.chromium.org/2766393004/diff/40001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/input/CursorAnchorInfoControllerTest.java
(right):

https://codereview.chromium.org/2766393004/diff/40001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/input/CursorAnchorInfoControllerTest.java:95:
private static class AssertionHelper {
On 2017/04/04 at 00:39:55, jbudorick wrote:
> What's the motivation behind moving these into a private static class?

Because CursorAnchorInfo is lollipop and above, JUnit4's run mechanism or using
reflection cause the test to crash.

[jbudorick, 2017-04-04 19:51:17]

lgtm

https://codereview.chromium.org/2766393004/diff/40001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/input/CursorAnchorInfoControllerTest.java
(right):

https://codereview.chromium.org/2766393004/diff/40001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/input/CursorAnchorInfoControllerTest.java:95:
private static class AssertionHelper {
On 2017/04/04 17:41:25, the real yoland wrote:
> On 2017/04/04 at 00:39:55, jbudorick wrote:
> > What's the motivation behind moving these into a private static class?
> 
> Because CursorAnchorInfo is lollipop and above, JUnit4's run mechanism or
using
> reflection cause the test to crash.

huh, interesting.

[the real yoland, 2017-04-12 17:14:25]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 17:15:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 17:47:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 17:47:11]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[the real yoland, 2017-04-13 00:50:28]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 00:51:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[the real yoland, 2017-04-13 00:51:46]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[the real yoland, 2017-04-13 00:51:51]

Patchset #6 (id:100001) has been deleted

[commit-bot: I haz the power, 2017-04-13 00:52:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 00:59:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 00:59:23]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[the real yoland, 2017-04-13 02:03:58]

Patchset #6 (id:120001) has been deleted

[the real yoland, 2017-04-13 02:04:04]

Patchset #6 (id:140001) has been deleted

[the real yoland, 2017-04-13 02:31:07]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 02:32:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 03:28:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 03:28:43]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[the real yoland, 2017-04-18 02:58:27]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 02:58:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 04:35:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 04:35:30]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[the real yoland, 2017-04-18 19:16:24]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[the real yoland, 2017-04-18 19:16:35]

The CQ bit was unchecked by yolandyan@chromium.org

[the real yoland, 2017-04-18 19:17:46]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 19:18:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 20:53:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 20:53:16]

Dry run: This issue passed the CQ dry run.

[the real yoland, 2017-04-18 21:20:44]

The CQ bit was checked by yolandyan@chromium.org

[the real yoland, 2017-04-18 21:20:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2766393004/#ps280001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-18 21:21:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 21:29:37]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1492550444811450,
"parent_rev": "74e44d1e750a7780d268d7713c0e07a6b349e795", "commit_rev":
"c38c29e5447a9e3b8188dcecd343a7a8533d3d0d"}

[commit-bot: I haz the power, 2017-04-18 21:29:51]

Description was changed from

==========
Convert most of the rest of instrumentation tests in content

For more on JUnit4 migration, check src/testing/android/docs/junit4.md

BUG=640116
==========

to

==========
Convert most of the rest of instrumentation tests in content

For more on JUnit4 migration, check src/testing/android/docs/junit4.md

BUG=640116

Review-Url: https://codereview.chromium.org/2766393004
Cr-Commit-Position: refs/heads/master@{#465379}
Committed:
https://chromium.googlesource.com/chromium/src/+/c38c29e5447a9e3b8188dcecd343...
==========

[commit-bot: I haz the power, 2017-04-18 21:29:52]

Committed patchset #12 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/c38c29e5447a9e3b8188dcecd343...