Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2766383003: [turbofan] escape analysis: revisit of uses afer FinishRegion marked as escaped (Closed)

Created:
3 years, 9 months ago by Tobias Tebbi
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] escape analysis: revisit of uses afer FinishRegion marked as escaped BUG=chromium:699251 R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2766383003 Cr-Commit-Position: refs/heads/master@{#44095} Committed: https://chromium.googlesource.com/v8/v8/+/0cfd2febcea9433bb856f7e729b2113c9f4e59c5

Patch Set 1 #

Patch Set 2 : repro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M src/compiler/escape-analysis.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/compiler/escape-analysis-15.js View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Tobias Tebbi
3 years, 9 months ago (2017-03-23 11:54:26 UTC) #1
Benedikt Meurer
LGTM once test added :-)
3 years, 9 months ago (2017-03-23 11:56:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766383003/1
3 years, 9 months ago (2017-03-24 09:14:02 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/19531) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 9 months ago (2017-03-24 09:20:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766383003/1
3 years, 9 months ago (2017-03-24 09:41:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_ng/builds/3173) v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 9 months ago (2017-03-24 09:48:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766383003/1
3 years, 9 months ago (2017-03-24 10:28:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766383003/2
3 years, 9 months ago (2017-03-24 10:56:22 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 11:21:15 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:2) as
https://chromium.googlesource.com/v8/v8/+/0cfd2febcea9433bb856f7e729b2113c9f4...

Powered by Google App Engine
This is Rietveld 408576698