Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2766383002: Reset need_trigger_scrollbar_show_ in SAC::DidMouseLeave (Closed)

Created:
3 years, 9 months ago by chaopeng
Modified:
3 years, 9 months ago
Reviewers:
weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset need_trigger_scrollbar_show_ in SAC::DidMouseLeave This issue is caused by need_trigger_scrollbar_show_ state not reset then no show event posted. BUG=704245 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2766383002 Cr-Commit-Position: refs/heads/master@{#459213} Committed: https://chromium.googlesource.com/chromium/src/+/e8caf7c191831e7272edede1ed32508557a2ce20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M cc/input/scrollbar_animation_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/input/scrollbar_animation_controller_unittest.cc View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
chaopeng
PTAL. Thank you.
3 years, 9 months ago (2017-03-22 19:11:30 UTC) #3
weiliangc
LGTM
3 years, 9 months ago (2017-03-23 18:40:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766383002/1
3 years, 9 months ago (2017-03-23 19:03:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/346786)
3 years, 9 months ago (2017-03-23 19:18:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766383002/1
3 years, 9 months ago (2017-03-23 20:01:53 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 21:00:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e8caf7c191831e7272edede1ed32...

Powered by Google App Engine
This is Rietveld 408576698