Add a ShapeResultBloberizer test for mixed rotations

Add a ShapeResultBloberizer test for mixed rotations

(follow-up to http://crrev.com/2714413003)

Adjust the mock SimpleFontData ctor (only used in ShapeResultBloberizerTest)
to allow passing custom OpenTypeVerticalData, and add a unit test for multiple
blobs/rotations construction.

Review-Url: https://codereview.chromium.org/2766373005
Cr-Commit-Position: refs/heads/master@{#459431}
Committed: https://chromium.googlesource.com/chromium/src/+/79ddf9920ca3221b5a6c8f5bca3252a5b0bec769

[f(malita), 2017-03-24 13:27:27]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 13:27:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-03-24 13:30:57]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 13:31:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-03-24 13:35:11]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 13:35:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-03-24 13:36:40]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 13:36:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-03-24 13:49:42]

Description was changed from

==========
Add a ShapeResultBloberizer test for mixed rotations

Follow-up to http://crrev.com/2714413003: add a unit test to exercise
multiple blobs/rotations construction.
==========

to

==========
Add a ShapeResultBloberizer test for mixed rotations

(follow-up to http://crrev.com/2714413003)

Adjust the mock SimpleFontData ctor (only used in ShapeResultBloberizerTest)
to allow passing custom OpenTypeVerticalData, and add a unit test for multiple
blobs/rotations construction.
==========

[f(malita), 2017-03-24 13:49:42]

fmalita@chromium.org changed reviewers:
+ drott@chromium.org

[f(malita), 2017-03-24 13:49:54]

fmalita@chromium.org changed reviewers:
+ eae@chromium.org

[drott, 2017-03-24 13:57:20]

Great, thanks for covering this case. LGTM. One nit below...

https://codereview.chromium.org/2766373005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/SimpleFontData.h (right):

https://codereview.chromium.org/2766373005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/SimpleFontData.h:167:
SimpleFontData(const FontPlatformData&, PassRefPtr<OpenTypeVerticalData>);
Could you perhaps add a comment here saying that this should be only used for
testing?

[f(malita), 2017-03-24 14:02:42]

https://codereview.chromium.org/2766373005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/SimpleFontData.h (right):

https://codereview.chromium.org/2766373005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/SimpleFontData.h:167:
SimpleFontData(const FontPlatformData&, PassRefPtr<OpenTypeVerticalData>);
On 2017/03/24 13:57:20, drott wrote:
> Could you perhaps add a comment here saying that this should be only used for
> testing?

Done.

[f(malita), 2017-03-24 14:02:46]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2017-03-24 14:02:46]

The patchset sent to the CQ was uploaded after l-g-t-m from drott@chromium.org
Link to the patchset: https://codereview.chromium.org/2766373005/#ps80001
(title: "review")

[commit-bot: I haz the power, 2017-03-24 14:03:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 15:38:41]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490364166040040,
"parent_rev": "ba244ac715ad0cc3e981a25076fd728b9e490e59", "commit_rev":
"79ddf9920ca3221b5a6c8f5bca3252a5b0bec769"}

[commit-bot: I haz the power, 2017-03-24 15:39:33]

Description was changed from

==========
Add a ShapeResultBloberizer test for mixed rotations

(follow-up to http://crrev.com/2714413003)

Adjust the mock SimpleFontData ctor (only used in ShapeResultBloberizerTest)
to allow passing custom OpenTypeVerticalData, and add a unit test for multiple
blobs/rotations construction.
==========

to

==========
Add a ShapeResultBloberizer test for mixed rotations

(follow-up to http://crrev.com/2714413003)

Adjust the mock SimpleFontData ctor (only used in ShapeResultBloberizerTest)
to allow passing custom OpenTypeVerticalData, and add a unit test for multiple
blobs/rotations construction.

Review-Url: https://codereview.chromium.org/2766373005
Cr-Commit-Position: refs/heads/master@{#459431}
Committed:
https://chromium.googlesource.com/chromium/src/+/79ddf9920ca3221b5a6c8f5bca32...
==========

[commit-bot: I haz the power, 2017-03-24 15:39:35]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/79ddf9920ca3221b5a6c8f5bca32...

[eae, 2017-03-24 18:14:03]

\o/
LGTM