Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2766373002: Notify inspector of stylesheet changes when removing tree scopes. (Closed)

Created:
3 years, 9 months ago by rune
Modified:
3 years, 9 months ago
Reviewers:
kochi
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, blink-reviews-dom_chromium.org, sof, eae+blinkwatch, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, rwlbuis, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify inspector of stylesheet changes when removing tree scopes. We did not update active stylesheet lists when removing a shadow since there is no collection to update. However, the inspector expects a notification since it receives a flat vector of active stylesheets from all scopes. Add a m_treeScopesRemoved member to not early return from updateActiveStyleSheets and still call probe::activeStyleSheetsUpdated. Unless other tree scopes are dirty, calling the inspector is all that happens. R=kochi@chromium.org BUG=703427 Review-Url: https://codereview.chromium.org/2766373002 Cr-Commit-Position: refs/heads/master@{#459039} Committed: https://chromium.googlesource.com/chromium/src/+/23338f51f914e86486a5742184b8a793699b4157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/inspector/elements/styles-3/remove-shadow-host.html View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/styles-3/remove-shadow-host-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
rune
ptal
3 years, 9 months ago (2017-03-22 19:04:44 UTC) #3
kochi
LGTM
3 years, 9 months ago (2017-03-23 10:15:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766373002/1
3 years, 9 months ago (2017-03-23 10:19:38 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 10:25:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/23338f51f914e86486a5742184b8...

Powered by Google App Engine
This is Rietveld 408576698