[Payments] Support canMakePayment on Desktop

[Payments] Support canMakePayment on Desktop

Filed bugs for missing features.

BUG=704706
TEST=components_unittests, browser_tests

Review-Url: https://codereview.chromium.org/2766353004
Cr-Commit-Position: refs/heads/master@{#459475}
Committed: https://chromium.googlesource.com/chromium/src/+/1a5be4fc4a86617e3c0700eb3be847989a7d175a

[Mathieu, 2017-03-23 21:55:36]

Description was changed from

==========
[Payments] Support canMakePayment on Desktop

Filed bugs for shortcomings.

BUG=704706
TEST=components_unittests, browser_tests
==========

to

==========
[Payments] Support canMakePayment on Desktop

Filed bugs for missing features.

BUG=704706
TEST=components_unittests, browser_tests
==========

[Mathieu, 2017-03-23 21:55:36]

mathp@chromium.org changed reviewers:
+ rouslan@chromium.org

[Mathieu, 2017-03-23 21:56:01]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 21:56:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-03-23 21:57:06]

Rouslan, PTAL

[commit-bot: I haz the power, 2017-03-23 23:47:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 23:47:39]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-03-24 14:47:25]

LGTM % comments

https://codereview.chromium.org/2766353004/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_browsertest.cc (right):

https://codereview.chromium.org/2766353004/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_browsertest.cc:163: }
Need to override the destructor.

https://codereview.chromium.org/2766353004/diff/1/chrome/browser/ui/views/pay...
File
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc
(right):

https://codereview.chromium.org/2766353004/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc:21:
"/payment_request_can_make_payment_query_test.html") {}
Need to override the destructor.

https://codereview.chromium.org/2766353004/diff/1/components/payments/content...
File components/payments/content/payment_request_state.cc (right):

https://codereview.chromium.org/2766353004/diff/1/components/payments/content...
components/payments/content/payment_request_state.cc:40: available_instruments_)
{
Need to filter by valid instruments (instrument->IsValid()).

https://codereview.chromium.org/2766353004/diff/1/components/payments/content...
File components/payments/content/payment_request_state.h (right):

https://codereview.chromium.org/2766353004/diff/1/components/payments/content...
components/payments/content/payment_request_state.h:61: bool CanMakePayment();
This method should be const.

[Mathieu, 2017-03-24 15:37:25]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 15:38:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-03-24 15:38:41]

Thanks, submitting

https://codereview.chromium.org/2766353004/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_browsertest.cc (right):

https://codereview.chromium.org/2766353004/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_browsertest.cc:163: }
On 2017/03/24 14:47:25, ಠ_ಠ slow - w3c wrote:
> Need to override the destructor.

I think we had this discussion in a previous change... I don't think we do? If
you feel strongly, let me know and I'll change it across all tests that subclass
PaymentRequestBrowserTestBase

https://codereview.chromium.org/2766353004/diff/1/chrome/browser/ui/views/pay...
File
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc
(right):

https://codereview.chromium.org/2766353004/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc:21:
"/payment_request_can_make_payment_query_test.html") {}
On 2017/03/24 14:47:25, ಠ_ಠ slow - w3c wrote:
> Need to override the destructor.

Acknowledged.

https://codereview.chromium.org/2766353004/diff/1/components/payments/content...
File components/payments/content/payment_request_state.cc (right):

https://codereview.chromium.org/2766353004/diff/1/components/payments/content...
components/payments/content/payment_request_state.cc:40: available_instruments_)
{
On 2017/03/24 14:47:25, ಠ_ಠ slow - w3c wrote:
> Need to filter by valid instruments (instrument->IsValid()).

Whoops, thanks.

https://codereview.chromium.org/2766353004/diff/1/components/payments/content...
File components/payments/content/payment_request_state.h (right):

https://codereview.chromium.org/2766353004/diff/1/components/payments/content...
components/payments/content/payment_request_state.h:61: bool CanMakePayment();
On 2017/03/24 14:47:25, ಠ_ಠ slow - w3c wrote:
> This method should be const.

Done.

[Mathieu, 2017-03-24 15:39:42]

The CQ bit was unchecked by mathp@chromium.org

[Mathieu, 2017-03-24 15:39:46]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-03-24 15:39:47]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2766353004/#ps20001
(title: "only support valid instruments, added test")

[commit-bot: I haz the power, 2017-03-24 15:40:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 17:07:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 17:07:25]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mathieu, 2017-03-24 17:26:14]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2017-03-24 17:27:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 18:09:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490376374782770,
"parent_rev": "502a0b3e580685f93a0319f433bcf150ddb6806d", "commit_rev":
"1a5be4fc4a86617e3c0700eb3be847989a7d175a"}

[commit-bot: I haz the power, 2017-03-24 18:11:28]

Description was changed from

==========
[Payments] Support canMakePayment on Desktop

Filed bugs for missing features.

BUG=704706
TEST=components_unittests, browser_tests
==========

to

==========
[Payments] Support canMakePayment on Desktop

Filed bugs for missing features.

BUG=704706
TEST=components_unittests, browser_tests

Review-Url: https://codereview.chromium.org/2766353004
Cr-Commit-Position: refs/heads/master@{#459475}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a5be4fc4a86617e3c0700eb3be8...
==========

[commit-bot: I haz the power, 2017-03-24 18:11:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1a5be4fc4a86617e3c0700eb3be8...

[stgao, 2017-03-28 20:51:16]

stgao@chromium.org changed reviewers:
+ stgao@chromium.org

[stgao, 2017-03-28 20:51:17]

This CL introduced a flaky test, see bug for detail
https://bugs.chromium.org/p/chromium/issues/detail?id=706146

[stgao, 2017-03-28 20:51:27]

Description was changed from

==========
[Payments] Support canMakePayment on Desktop

Filed bugs for missing features.

BUG=704706
TEST=components_unittests, browser_tests

Review-Url: https://codereview.chromium.org/2766353004
Cr-Commit-Position: refs/heads/master@{#459475}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a5be4fc4a86617e3c0700eb3be8...
==========

to

==========
[Payments] Support canMakePayment on Desktop

Filed bugs for missing features.

BUG=704706
TEST=components_unittests, browser_tests

Review-Url: https://codereview.chromium.org/2766353004
Cr-Commit-Position: refs/heads/master@{#459475}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a5be4fc4a86617e3c0700eb3be8...
==========

[stgao, 2017-03-28 20:51:27]

stgao@chromium.org changed reviewers:
- stgao@chromium.org