Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2766353002: Merge the patch back into M57 (Closed)

Created:
3 years, 9 months ago by yigu
Modified:
3 years, 9 months ago
Reviewers:
flackr, pdr.
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Remove logic about recording style related main thread scroll reasons The current recording incorrectly propagates the style related main thread scrolling reasons of a scrollable overflow element to the main frame. It would make the main frame scroll on main if there were any scrollers which needed to scroll on main which it shouldn't. It also caused 34.5% regression in smoothness.key_mobile_sites_smooth benchmark (crbug.com/693527) .As the issue is blocking release of M57 stable, it's better to remove the recording logic for now and work on a correct one in a following patch. BUG=701355 TBR=pdr@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2766893002 Cr-Commit-Position: refs/heads/master@{#458596} (cherry picked from commit d528436cf0ab46778ccd56a439a250e41113fc46) Review-Url: https://codereview.chromium.org/2766353002 Cr-Commit-Position: refs/branch-heads/2987@{#864} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/c8352fb469276b9d2d1bcef3fc93f202aa5c2b75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
yigu
PTAL. Thanks!
3 years, 9 months ago (2017-03-22 18:56:47 UTC) #3
flackr
lgtm
3 years, 9 months ago (2017-03-22 18:57:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766353002/1
3 years, 9 months ago (2017-03-22 18:58:40 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 19:08:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c8352fb469276b9d2d1bcef3fc93...

Powered by Google App Engine
This is Rietveld 408576698