Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2766343002: Revert of [Mojo Video Capture] Add test coverage for accelerated jpeg decoding (Closed)

Created:
3 years, 9 months ago by chfremer
Modified:
3 years, 9 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, piman+watch_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mojo Video Capture] Add test coverage for accelerated jpeg decoding (patchset #8 id:160001 of https://codereview.chromium.org/2735083002/ ) Reason for revert: Causes a ChromiumOS test failure, see https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/23888 Original issue's description: > [Mojo Video Capture] Add test coverage for accelerated jpeg decoding > > This CL adds test cases to VideoCaptureBrowserTest that exercise the code path > for accelerated jpeg decoding using a fake decode accelerator. > > * Add a FakeJpegDecodeAccelerator that can run in the GPU process and decodes > jpeg frames in software using libyuv. > * Add a command-line flag kUseFakeJpegDecodeAccelerator to enable the fake > accelerator (and suppress any "real" ones if present). > * Fix threading-related DCHECKs in GpuJpegDecodeAccelerator::Client to match > what is actually happening. This is needed to make the new test cases pass. > It also fixes issue 688184 [1]. > > This CL is part of the Mojo Video Capture work. For the bigger picture, > see [2] CL14. > > BUG=584797, 688184 > TEST= > content_browsertests --gtest_filter="VideoCaptureBrowserTest.*" > > [1] https://bugs.chromium.org/p/chromium/issues/detail?id=688184 > [2] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2735083002 > Cr-Commit-Position: refs/heads/master@{#458782} > Committed: https://chromium.googlesource.com/chromium/src/+/ac2f201c499c2d65a5d43b6ce49d9af5b4520f99 TBR=posciak@chromium.org,emircan@chromium.org,mcasas@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584797, 688184 Review-Url: https://codereview.chromium.org/2766343002 Cr-Commit-Position: refs/heads/master@{#458820} Committed: https://chromium.googlesource.com/chromium/src/+/da3f614dc0e3d04f62227cddb136997731dcd443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -329 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_browsertest.cc View 6 chunks +11 lines, -39 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 4 chunks +12 lines, -31 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_event_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_host.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_frame_receiver_on_io_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_frame_receiver_on_io_thread.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/media_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/capture/video/video_capture_device_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/capture/video/video_capture_device_client.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M media/capture/video/video_capture_device_client_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/capture/video/video_frame_receiver.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D media/gpu/fake_jpeg_decode_accelerator.h View 1 chunk +0 lines, -69 lines 0 comments Download
D media/gpu/fake_jpeg_decode_accelerator.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc View 7 chunks +14 lines, -37 lines 0 comments Download
M services/video_capture/receiver_mojo_to_media_adapter.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/video_capture/receiver_mojo_to_media_adapter.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
chfremer
Created Revert of [Mojo Video Capture] Add test coverage for accelerated jpeg decoding
3 years, 9 months ago (2017-03-22 18:37:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766343002/1
3 years, 9 months ago (2017-03-22 18:38:01 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 18:54:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da3f614dc0e3d04f62227cddb136...

Powered by Google App Engine
This is Rietveld 408576698