Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2766333002: Use llvm-ar when building with Clang. (Closed)

Created:
3 years, 9 months ago by krasin1
Modified:
3 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use llvm-ar when building with Clang. llvm-ar is faster and is capable of handling LLVM bitcode files without a need for a Gold plugin. BUG=660216, 607968 Review-Url: https://codereview.chromium.org/2766333002 Cr-Commit-Position: refs/heads/master@{#460129} Committed: https://chromium.googlesource.com/chromium/src/+/8968cd5170f4a22b1c508ffa3bc240b346c44b1b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M build/config/compiler/BUILD.gn View 1 2 chunks +2 lines, -6 lines 0 comments Download
M build/config/posix/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
krasin1
3 years, 8 months ago (2017-03-27 17:03:49 UTC) #3
Nico
Lgtm, but let's wait a few hours to make sure the roll sticks. Thanks! https://codereview.chromium.org/2766333002/diff/1/build/config/compiler/BUILD.gn ...
3 years, 8 months ago (2017-03-27 17:10:39 UTC) #5
krasin1
Sure, I will wait. https://codereview.chromium.org/2766333002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2766333002/diff/1/build/config/compiler/BUILD.gn#newcode305 build/config/compiler/BUILD.gn:305: cflags += [ "-pipe" ] ...
3 years, 8 months ago (2017-03-27 17:51:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766333002/20001
3 years, 8 months ago (2017-03-28 16:00:30 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 16:47:07 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8968cd5170f4a22b1c508ffa3bc2...

Powered by Google App Engine
This is Rietveld 408576698