Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2766313003: Rename Suggestions to ContentSuggestions in Showcase (Closed)

Created:
3 years, 9 months ago by gambard
Modified:
3 years, 9 months ago
Reviewers:
lpromero
CC:
chromium-reviews, marq+watch_chromium.org, lpromero+watch_chromium.org, ios-reviews_chromium.org, ios-reviews+showcase_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Suggestions to ContentSuggestions in Showcase This CL renames the Suggestions feature in showcase to be consistent with the name in Chrome. BUG=704493 Review-Url: https://codereview.chromium.org/2766313003 Cr-Commit-Position: refs/heads/master@{#459073} Committed: https://chromium.googlesource.com/chromium/src/+/9d21d637803bb3b0e674ca2c060aac9947146fab

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -129 lines) Patch
M ios/showcase/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
A + ios/showcase/content_suggestions/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
A ios/showcase/content_suggestions/sc_content_suggestions_coordinator.h View 1 chunk +15 lines, -0 lines 0 comments Download
A + ios/showcase/content_suggestions/sc_content_suggestions_coordinator.mm View 3 chunks +3 lines, -3 lines 0 comments Download
A + ios/showcase/content_suggestions/sc_content_suggestions_egtest.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ios/showcase/core/showcase_model.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
D ios/showcase/suggestions/BUILD.gn View 1 chunk +0 lines, -29 lines 0 comments Download
D ios/showcase/suggestions/sc_suggestions_coordinator.h View 1 chunk +0 lines, -15 lines 0 comments Download
D ios/showcase/suggestions/sc_suggestions_coordinator.mm View 1 chunk +0 lines, -47 lines 0 comments Download
D ios/showcase/suggestions/sc_suggestions_egtest.mm View 1 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
gambard
PTAL.
3 years, 9 months ago (2017-03-23 10:34:01 UTC) #2
lpromero
lgtm
3 years, 9 months ago (2017-03-23 11:30:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766313003/1
3 years, 9 months ago (2017-03-23 11:30:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/61318) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-23 11:32:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766313003/20001
3 years, 9 months ago (2017-03-23 12:17:52 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/346457)
3 years, 9 months ago (2017-03-23 13:11:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766313003/20001
3 years, 9 months ago (2017-03-23 13:51:26 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 14:16:33 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9d21d637803bb3b0e674ca2c060a...

Powered by Google App Engine
This is Rietveld 408576698