Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issue 2766283002: [inspector] follow up for e27d18c94337f908d75fdccb4c5263180dbb1511 (Closed)

Created:
3 years, 9 months ago by kozy
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, Yang, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] follow up for e27d18c94337f908d75fdccb4c5263180dbb1511 - renamed inspector-test methods, - tuned comment in debug.h BUG=v8:6118 TBR=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2766283002 Cr-Commit-Position: refs/heads/master@{#44043} Committed: https://chromium.googlesource.com/v8/v8/+/69ad35ac6b5e913cba2d9daff082e0a3fd6b36d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M src/debug/debug.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/inspector/debugger/stepping-tail-call.js View 1 chunk +5 lines, -5 lines 0 comments Download
M test/inspector/debugger/stepping-with-natives-and-frameworks.js View 1 chunk +5 lines, -5 lines 0 comments Download
M test/inspector/protocol-test.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766283002/1
3 years, 9 months ago (2017-03-22 17:20:19 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 18:07:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/69ad35ac6b5e913cba2d9daff082e0a3fd6...

Powered by Google App Engine
This is Rietveld 408576698