Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2766263005: Add UMA to record WorkerThread runtime (Closed)

Created:
3 years, 9 months ago by kinuko
Modified:
3 years, 9 months ago
CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA to record WorkerThread runtime We have one for ServiceWorker but don't have the stat for other workers. Having it would be useful to add other stats like WorkerThread CPU Load UMA (https://codereview.chromium.org/2749383003/) BUG=692906 Review-Url: https://codereview.chromium.org/2766263005 Cr-Commit-Position: refs/heads/master@{#459349} Committed: https://chromium.googlesource.com/chromium/src/+/c71427629a142302c08179360116f7a0125b90cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.cc View 3 chunks +12 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
kinuko
PTL (Context: https://codereview.chromium.org/2749383003/#msg19, we want to know how long worker threads typically last)
3 years, 9 months ago (2017-03-23 09:38:59 UTC) #4
nhiroki
lgtm
3 years, 9 months ago (2017-03-23 10:31:50 UTC) #6
altimin
lgtm
3 years, 9 months ago (2017-03-23 11:18:35 UTC) #9
kinuko
asvitkine@chromium.org: could you review histogram change?
3 years, 9 months ago (2017-03-23 11:31:28 UTC) #11
kinuko
On 2017/03/23 11:31:28, kinuko wrote: > mailto:asvitkine@chromium.org: could you review histogram change? oops he seems ...
3 years, 9 months ago (2017-03-23 11:34:16 UTC) #13
Ilya Sherman
metrics lgtm
3 years, 9 months ago (2017-03-23 19:31:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766263005/1
3 years, 9 months ago (2017-03-24 03:00:08 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 03:08:04 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c71427629a142302c08179360116...

Powered by Google App Engine
This is Rietveld 408576698